baremetal Virtual_power_driver can return incorrect power status

Bug #1152676 reported by Chris Krelle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Krelle

Bug Description

is_power_on function of virtual power driver can return inaccurate results if a nodes name is a substring of another node.

Example:
create two vm nodes named: "PxeNode", and "PxeNode01"
nova boot both nodes
nova delete PxeNode

In its current state vpd is_power_on function would match PxeNode and PxeNode01 there by returning a false error believing the vm had not correctly powered off

Tags: baremetal
Chris Krelle (nobodycam)
Changed in nova:
assignee: nobody → Chris Krelle (nobodycam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23939

Changed in nova:
status: New → In Progress
aeva black (tenbrae)
Changed in nova:
importance: Undecided → Low
aeva black (tenbrae)
Changed in nova:
importance: Low → Medium
milestone: none → grizzly-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23939
Committed: http://github.com/openstack/nova/commit/79c55682dd51a8c2098c3aead8a0783a592429c5
Submitter: Jenkins
Branch: master

commit 79c55682dd51a8c2098c3aead8a0783a592429c5
Author: Chris Krelle <email address hidden>
Date: Fri Mar 8 09:22:19 2013 -0800

    Correct substring matching of baremetal VPD node names

    This path corrects a issue where is_power_on function can incorrectly match a
    node if its name is a substring of another node.

    I have also added a test for this.

    fixes bug 1152676
    Change-Id: Ic3b0b952d53dcd4464098f98879a84684efe22b2
    Authored-by: Chris Krelle <email address hidden>

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.