vif_type not in existed instances info_cache cause upgrade from folsom to grizzly fails

[Yaguang Tang]

when upgrade from folsom to grizzly, nova-compute can't starts because vif_type is None, vif_type is added to networkinfo model in grizzly, so when upgrade a folsom env to grizzly, existing instances's info_cache need to update to set this param.

log info:

  File "/home/yaguang/working/openstack/nova/nova/service.py", line 147, in run_server
    server.start()
  File "/home/yaguang/working/openstack/nova/nova/service.py", line 429, in start
    self.manager.init_host()
  File "/home/yaguang/working/openstack/nova/nova/compute/manager.py", line 574, in init_host
    self._init_instance(context, instance)
  File "/home/yaguang/working/openstack/nova/nova/compute/manager.py", line 463, in _init_instance
    self.driver.plug_vifs(instance, legacy_net_info)
  File "/home/yaguang/working/openstack/nova/nova/virt/libvirt/driver.py", line 686, in plug_vifs
    self.vif_driver.plug(instance, (network, mapping))
  File "/home/yaguang/working/openstack/nova/nova/virt/libvirt/vif.py", line 391, in plug
    _("vif_type parameter must be present "
NovaException: vif_type parameter must be present for this vif_driver implementation

[Thierry Carrez (ttx)]

https://review.openstack.org/#/c/23888/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23888
Committed: http://github.com/openstack/nova/commit/45e65d8c0301da689de1afcbc9f45756e71097ab
Submitter: Jenkins
Branch: master

commit 45e65d8c0301da689de1afcbc9f45756e71097ab
Author: Yaguang Tang <email address hidden>
Date: Fri Mar 8 11:29:43 2013 +0800

    Update instance network info cache to include vif_type.

    vif_type is a new param in legacy_nw_info added in grizzly, and when upgrading
    from folsom to grizzly, the existing instance's network info cache in the db doesn't
    contain this param, which is needed by vif driver to plug vif to instance. Nova
    compute will try to plug the vif when it starts the instance, so we need to update
    the existing instance's network info cache before pluging instance's VIF.

    fix bug #1152426

    Change-Id: I1b839bf791b402b933354d9c17c5713fde21ab09

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/25417

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25417
Committed: http://github.com/openstack/nova/commit/ddff7707be535bd082f291bb38b31406f338cefe
Submitter: Jenkins
Branch: milestone-proposed

commit ddff7707be535bd082f291bb38b31406f338cefe
Author: Yaguang Tang <email address hidden>
Date: Fri Mar 8 11:29:43 2013 +0800

    Update instance network info cache to include vif_type.

    vif_type is a new param in legacy_nw_info added in grizzly, and when upgrading
    from folsom to grizzly, the existing instance's network info cache in the db doesn't
    contain this param, which is needed by vif driver to plug vif to instance. Nova
    compute will try to plug the vif when it starts the instance, so we need to update
    the existing instance's network info cache before pluging instance's VIF.

    fix bug #1152426

    Change-Id: I1b839bf791b402b933354d9c17c5713fde21ab09
    (cherry picked from commit 45e65d8c0301da689de1afcbc9f45756e71097ab)