glance-scrubber crashes if Swift returns 404

Bug #1152252 reported by Paul Bourke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Paul Bourke
Grizzly
Fix Released
Undecided
Paul Bourke

Bug Description

If the image object that a queue file refers to happens to go missing from the backend, the _delete function is not catching this exception and causing the app to fall over constantly.

Changed in glance:
assignee: nobody → Paul Bourke (pauldbourke)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/23827
Committed: http://github.com/openstack/glance/commit/53c4f7c34b6cbbe94bf47dc6ddfea04e9d857c28
Submitter: Jenkins
Branch: master

commit 53c4f7c34b6cbbe94bf47dc6ddfea04e9d857c28
Author: Paul Bourke <email address hidden>
Date: Wed Mar 6 16:54:23 2013 +0000

    Handle Swift 404 in scrubber

    If the image object happened to go missing from the backend, the _delete
    function was not catching this exception and caused the app to fall over
    constantly.

    Also:
    * Log the image id rather than uri in the case of UnsupportedBackend to
      avoid printing out credentials.

    * Refactor the 'wait for build servers' snippet into a function.
      Jason Kölker's note says the purpose is to wait up to 5 mins, checking
      every 15 seconds, though the code currently was only waiting 15 seconds.
      I have fixed this up as part of the move.

    Fixes bug #1152252

    Change-Id: Ifb74d7bc95b3245002291396ffabd8c5d729a1ac

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.