Scratch

File Manager extension causes a crash when viewing empty directories

Bug #1152182 reported by jogu
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
High
Jeremy Wootten
Scratch 2.0 "Inferno"

Bug Description

The File manager extension causes a crash when viewing an empty directory. When you expand an empty directory there's a single child with no name and an icon. Clicking this entry causes scratch to close.

Related branches

lp:~mefrio-g/scratch/rework
Danielle Foré: Approve
Sergey "Shnatsel" Davidoff (community): Needs Fixing
Cody Garver: Pending requested
Diff: 38298 lines (+3995/-32753) (has conflicts)
137 files modified
CMakeLists.txt (+12/-14)
README (+1/-1)
org.pantheon.scratch.gschema.xml (+0/-179)
plugins/CMakeLists.txt (+3/-3)
plugins/browser-preview/CMakeLists.txt (+0/-1)
plugins/browser-preview/browser-preview.vala (+64/-64)
plugins/contractor/CMakeLists.txt (+0/-1)
plugins/contractor/contractor.plugin (+1/-1)
plugins/contractor/contractor.vala (+59/-38)
plugins/devhelp/CMakeLists.txt (+0/-43)
plugins/devhelp/devhelp.plugin (+0/-10)
plugins/devhelp/devhelp.vala (+0/-97)
plugins/filemanager/CMakeLists.txt (+16/-17)
plugins/filemanager/filemanager.vala (+44/-12)
plugins/filemanager/marlincore.vala (+43/-37)
plugins/open-with/CMakeLists.txt (+23/-0)
plugins/open-with/open-with.plugin (+9/-0)
plugins/open-with/open-with.vala (+81/-0)
plugins/pastebin/CMakeLists.txt (+15/-16)
plugins/pastebin/pastebin.plugin (+1/-1)
plugins/pastebin/pastebin.vala (+15/-21)
plugins/pastebin/pastebin_dialog.vala (+25/-60)
plugins/spell-check/CMakeLists.txt (+0/-38)
plugins/spell-check/spell-check.plugin (+0/-10)
plugins/spell-check/spell-check.vala (+0/-64)
plugins/spell/CMakeLists.txt (+37/-0)
plugins/spell/spell.plugin (+10/-0)
plugins/spell/spell.vala (+59/-0)
plugins/strip-trailing-save/CMakeLists.txt (+0/-1)
plugins/strip-trailing-save/strip-trailing-save.vala (+9/-15)
plugins/terminal/CMakeLists.txt (+0/-1)
plugins/terminal/terminal.vala (+61/-52)
po/CMakeLists.txt (+2/-2)
po/am.po (+0/-517)
po/ar.po (+0/-519)
po/bg.po (+0/-517)
po/ca.po (+0/-525)
po/cs.po (+0/-524)
po/da.po (+0/-519)
po/de.po (+0/-518)
po/en_AU.po (+0/-519)
po/en_CA.po (+0/-525)
po/en_GB.po (+0/-525)
po/eo.po (+0/-518)
po/es.po (+0/-529)
po/eu.po (+0/-525)
po/fa.po (+0/-525)
po/fi.po (+0/-519)
po/fr.po (+0/-533)
po/gl.po (+0/-525)
po/hi.po (+0/-519)
po/hr.po (+0/-519)
po/hu.po (+0/-525)
po/id.po (+0/-524)
po/it.po (+0/-527)
po/ja.po (+0/-517)
po/jv.po (+0/-517)
po/km.po (+0/-523)
po/ko.po (+0/-517)
po/lt.po (+0/-517)
po/lv.po (+0/-520)
po/ml.po (+0/-517)
po/ms.po (+0/-523)
po/nb.po (+0/-525)
po/ne.po (+0/-518)
po/nl.po (+0/-524)
po/nn.po (+0/-517)
po/oc.po (+0/-517)
po/pl.po (+0/-525)
po/pt.po (+0/-511)
po/pt_BR.po (+0/-526)
po/ro.po (+0/-525)
po/ru.po (+0/-524)
po/rue.po (+0/-517)
po/scratch-text-editor.pot (+471/-0)
po/scratch.pot (+0/-509)
po/sk.po (+0/-517)
po/sl.po (+0/-517)
po/sr.po (+0/-520)
po/th.po (+0/-517)
po/tr.po (+0/-520)
po/uk.po (+0/-518)
po/vi.po (+0/-523)
po/zh_CN.po (+0/-523)
po/zh_TW.po (+0/-523)
schemas/CMakeLists.txt (+2/-0)
schemas/org.pantheon.scratch.gschema.xml (+179/-0)
scratchcore/CMakeLists.txt (+0/-82)
scratchcore/FileHandler.vala (+0/-141)
scratchcore/PluginManager.vala (+0/-322)
scratchcore/SearchManager.vala (+0/-525)
scratchcore/Settings.vala (+0/-90)
scratchcore/SourceView.vala (+0/-233)
scratchcore/TemplateManager.vala (+0/-207)
scratchcore/core-tests/CMakeLists.txt (+0/-33)
scratchcore/core-tests/main.vala (+0/-106)
scratchcore/main.vala (+0/-9)
scratchcore/scratchcore.pc.cmake (+0/-12)
src/CMakeLists.txt (+42/-22)
src/Dialogs/PreferencesDialog.vala (+55/-44)
src/Dialogs/SaveDialog.vala (+0/-114)
src/Dialogs/SaveOnCloseDialog.vala (+0/-52)
src/Dialogs/WarnDialog.vala (+0/-92)
src/MainWindow.vala (+393/-876)
src/Scratch.vala (+72/-152)
src/Services/Document.vala (+458/-764)
src/Services/Encoding.vala (+2/-2)
src/Services/FileHandler.vala (+128/-0)
src/Services/PluginManager.vala (+182/-0)
src/Services/Settings.vala (+90/-0)
src/Services/TemplateManager.vala (+236/-0)
src/Services/ZeitgeistLogger.vala (+2/-2)
src/Utils.vala (+49/-0)
src/Widgets/ComboSyntax.vala (+0/-65)
src/Widgets/DocumentView.vala (+154/-0)
src/Widgets/Notebook.vala (+0/-219)
src/Widgets/NotificationBar.vala (+0/-120)
src/Widgets/SearchManager.vala (+375/-0)
src/Widgets/ShareMenu.vala (+0/-63)
src/Widgets/SourceView.vala (+237/-0)
src/Widgets/SplitView.vala (+140/-115)
src/Widgets/StatusBar.vala (+0/-47)
src/Widgets/Tab.vala (+0/-269)
src/Widgets/TabLabel.vala (+0/-157)
src/Widgets/ToolBar.vala (+58/-162)
src/scratch-ui.xml (+27/-0)
src/scratch.deps (+0/-7)
src/scratch.pc.cmake (+0/-12)
src/scratchcore.deps (+7/-0)
src/scratchcore.pc.cmake (+12/-0)
tests/template_test/README (+0/-1)
vapi/gtkspell-3.0.deps (+0/-1)
vapi/gtkspell-3.0.vapi (+0/-24)
vapi/libdevhelp-3.0.deps (+0/-2)
vapi/libdevhelp-3.0.vapi (+0/-213)
vapi/libpeas-gtk-1.0.vapi (+34/-0)
vapi/peas-gtk.vapi (+0/-34)
Revision history for this message
jogu (jogu-sd) wrote :

Screenshot of an empty directory (Public)

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Fixed marlincore.vala so that dummy row in treeview is not rendered and cannot be selected.

Revision history for this message
Cody Garver (codygarver) wrote :

Hey Jeremy, thanks for the submission. Please submit it in the form of a patch.

bzr branch lp:pantheon-files
cd pantheon-files
# make changes
bzr diff > ~/pantheon-files-fix-1152182.diff
# attach diff to this bug.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Here is patch in diff form

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

Hey Jeremy I am going to push a rewrite of Scratch source code which will include an API break for plugins. As soon as you will notice it, you could patch your fix to fit the new scratch's version. Anyway thank you for the fix!

Changed in scratch:
status: New → Confirmed
importance: Undecided → High
milestone: none → 1.2
assignee: nobody → Jordan Guymon (jogu-sd)
assignee: Jordan Guymon (jogu-sd) → Jeremy Wootten (jeremywootten)
Revision history for this message
Jeremy Wootten (jeremywootten) wrote : Re: [Bug 1152182] Re: File Manager extension causes a crash when viewing empty directories

OK, thanks. I'll look out for the change.

On 20 April 2013 20:10, Mario Guerriero <email address hidden> wrote:

> Hey Jeremy I am going to push a rewrite of Scratch source code which
> will include an API break for plugins. As soon as you will notice it,
> you could patch your fix to fit the new scratch's version. Anyway thank
> you for the fix!
>
> ** Changed in: scratch
> Status: New => Confirmed
>
> ** Changed in: scratch
> Importance: Undecided => High
>
> ** Changed in: scratch
> Milestone: None => 1.2
>
> ** Changed in: scratch
> Assignee: (unassigned) => Jordan Guymon (jogu-sd)
>
> ** Changed in: scratch
> Assignee: Jordan Guymon (jogu-sd) => Jeremy Wootten (jeremywootten)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1152182
>
> Title:
> File Manager extension causes a crash when viewing empty directories
>
> Status in Scratch:
> Confirmed
>
> Bug description:
> The File manager extension causes a crash when viewing an empty
> directory. When you expand an empty directory there's a single child
> with no name and an icon. Clicking this entry causes scratch to close.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/scratch/+bug/1152182/+subscriptions
>

--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

hey I noticed that your patch can be applied to the branch with the scratch's rewrite and I did it. Thank you! :)

Changed in scratch:
status: Confirmed → In Progress
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

thanks Mario.

Incidentally, I looked at bug 1093352 and had a simple patch which fixed
the tab width to a constant value (hard coded). I was looking into whether
you could replace the Gtk.Notebook with a Granite.Widgets.DynamicNotebook
to achieve the same thing but with a variable equal width the same as
Terminal etc. This would also improve consistency with other parts of
Pantheon, but may not be very straightforward. Is this a good idea?

 I see that you have adopted this bug now anyway.

Being new to this collaborative development game, I an not sure of the
correct procedure if I want to work on a bug?

On 28 April 2013 18:53, Mario Guerriero <email address hidden> wrote:

> hey I noticed that your patch can be applied to the branch with the
> scratch's rewrite and I did it. Thank you! :)
>
> ** Changed in: scratch
> Status: Confirmed => In Progress
>
> ** Branch linked: lp:~mefrio-g/scratch/rework
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1152182
>
> Title:
> File Manager extension causes a crash when viewing empty directories
>
> Status in Scratch:
> In Progress
>
> Bug description:
> The File manager extension causes a crash when viewing an empty
> directory. When you expand an empty directory there's a single child
> with no name and an icon. Clicking this entry causes scratch to close.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/scratch/+bug/1152182/+subscriptions
>

--
Jeremy Wootten
GPG Key ID CB585BCD
Key Fingerprint 37C0 3C2A A6D4 E45B BA7C 4328 2DF2 1882 CB58 5BCD

Mario Guerriero (mefrio-g)
Changed in scratch:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.