NVP Plugin: 500 if removing a non-existent interface from a router

[Salvatore Orlando]

The NVP plugin is a bit optimistic and assumes the user will always pass a reference to an interface which exists on the router when removing an interface via PUT v2.0/routers/<id>/interface-remove, and therefore it crashes returning a 500.

The same code used in l3_db should be adopted. Possibly, NVP plugin should invoke the superclass method instead of overriding it entirely.

[dan wendlandt (danwent)]

this more of a corner case, so i'm pushing it down to a medium, as we would not block RC1 on this.

[Salvatore Orlando (salvatore-orlando)]

Sorry I mistakenly set it to high.
Yes this is not a blocker at all
Il giorno 08/mar/2013 16:55, "dan wendlandt" <email address hidden>
ha scritto:

> this more of a corner case, so i'm pushing it down to a medium, as we
> would not block RC1 on this.
>
> ** Changed in: quantum
> Importance: High => Medium
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/1152167
>
> Title:
> NVP Plugin: 500 if removing a non-existent interface from a router
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> The NVP plugin is a bit optimistic and assumes the user will always
> pass a reference to an interface which exists on the router when
> removing an interface via PUT v2.0/routers/<id>/interface-remove, and
> therefore it crashes returning a 500.
>
> The same code used in l3_db should be adopted. Possibly, NVP plugin
> should invoke the superclass method instead of overriding it entirely.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1152167/+subscriptions
>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23976

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23976
Committed: http://github.com/openstack/quantum/commit/4cf7deb940ea02042e6d95ca48cb250230969e4c
Submitter: Jenkins
Branch: master

commit 4cf7deb940ea02042e6d95ca48cb250230969e4c
Author: Salvatore Orlando <email address hidden>
Date: Sat Mar 9 01:30:39 2013 +0100

    NVP plugin: return 409 if wrong router interface info on remove

    Bug 1152167

    Raise an exception causing a 409 error to be returned if port_id or
    subnet_id specified in request body do not exist before further
    processing the operation (which will cause a 500 error to be
    returned to the user)

    Change-Id: I347dd86da87ce5b1e57e139e4c21d4533a456cbc