boot with volume lacks disk serial number

[MotoKen]

when an instance attach volume, the libvirt xml looks like:

<disk type='block' device='disk'>
  <driver name='qemu' type='raw' cache='none'/>
  <source dev='/dev/disk/by-path/ip-192.168.1.1:3260-iscsi-iqn.2010-10.org.openstack:volume-bb0512b4-ce6c-46f6-bed9-c74704eba87a-lun-0'/>
  <target dev='vdd' bus='virtio'/>
  <serial>bb0512b4-ce6c-46f6-bed9-c74704eba87a</serial>
  <alias name='virtio-disk3'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
</disk>

however, when an instance boot with volume, the libvirt xml lacks the 'serial' element:

<disk type='block' device='disk'>
  <driver name='qemu' type='raw' cache='none'/>
  <source dev='/dev/disk/by-path/ip-192.168.1.1:3260-iscsi-iqn.2010-10.org.openstack:volume-1a9ca4f2-0151-45c3-b0e7-196615bc6773-lun-0'/>
  <target dev='vdd' bus='virtio'/>
  <alias name='virtio-disk3'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
</disk>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24363

[Daniel Berrange (berrange)]

FWIW, our use of UUIDs for serial strings sucks - they are too long & get truncated. I filed https://bugs.launchpad.net/nova/+bug/1155228 to track an improvement for this

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24363
Committed: http://github.com/openstack/nova/commit/2d0578c539d000981e50ba0c143385974d10e2e2
Submitter: Jenkins
Branch: master

commit 2d0578c539d000981e50ba0c143385974d10e2e2
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Mar 13 13:51:38 2013 -0700

    Add the serial to connection info for boot volumes

    The serial parameter wasn't being added to volumes specified at
    boot time. Added tests. Also cleaned up import in test_compute
    to match the rest of the file.

    Fixes bug 1148734

    Change-Id: I05a623849680c5d0bb530fba4c4e6051d3b000aa