Use of BIGINT column type affects testing with sqlite
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Low
|
Kaushik Chandrashekar | ||
Bug Description
The problem is sqlalchemy doesn't recognize the type BigInt
Step to reproduce this issue:
Run the unit tests,
$./run_tests.sh api
Then check the logs,
$head -100 subunit.log
time: 2013-03-05 21:47:33.002802Z
test: nova.tests.
time: 2013-03-05 21:47:34.087936Z
tags: worker-1
successful: nova.tests.
Content-Type: text/plain;
pythonlogging:
2A1
Loading network driver 'nova.network.
Starting conductor node (version 2013.1)
Loading compute driver 'nova.virt.
Starting compute node (version 2013.1)
Updating host status
Auditing locally available compute resources
Free ram (MB): 7680
Free disk (GB): 1028
Free VCPUS: 1
Compute_service record created for 07698146867b4ee
Starting scheduler node (version 2013.1)
Loading network driver 'nova.network.
Starting network node (version 2013.1)
Create volume of 1 GB
creating volume 2a22fa5a-
Create snapshot of volume vol-00000001
deleting volume 2a22fa5a-
0
Content-Type: text/plain;
stderr
AC5
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
default, primary_key))
/home/kaushikc/
return self._in_
0
Content-Type: text/plain;
stdout
0
]
The same problem happens while running tests with other tools like nosetests
$ nosetests
nosetests nova/tests/
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
/usr/local/
default, primary_key))
..........
-------
Ran 10 tests in 1.493s
OK
Since the warnings are in stderr, some editor plugins (like pyunit) to run unit tests in place, are not working.
| Changed in nova: | |
| assignee: | nobody → Kaushik Chandrashekar (kaushikc) |
| tags: | added: low-hanging-fruit |
| Changed in nova: | |
| status: | New → Confirmed |
| aeva black (tenbrae) wrote | #1 |
| Changed in nova: | |
| importance: | Undecided → Low |
| tags: | added: db |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to nova (master) | #2 |
| Changed in nova: | |
| status: | Confirmed → In Progress |
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #3 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → grizzly-rc1 |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | grizzly-rc1 → 2013.1 |
I'm fairly sure that sqla is just converting these to INT type, which in sqlite can accommodate up to 8 bytes already. I don't think the tests are adversely affected, it's just the warning gives the impression something is wrong when it isn't. This is really an issue in sqla, but it would be nice to not see those warnings all the time.