OpenStack Compute (nova)

trying to delete an instance in 'RESIZE' state fails

Bug #1147387 reported by Dan Prince on 2013-03-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	High	Dan Prince	OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

Using recent Nova grizzly code (git bcafae5) I'm now seeing the following exception when I try to delete an instance in the RESIZE state.

2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp temp_level, payload)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp self.gen.next()
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/exception.py", line 88, in wrapped
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp return f(self, context, *args, **kw)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 256, in decorated_function
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp event_name, instance_uuid):
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/compute/utils.py", line 317, in __enter__
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp self.conductor.action_event_start(self.context, event)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/conductor/api.py", line 261, in action_event_start
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp return self._manager.action_event_start(context, values)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/utils.py", line 1430, in wrapper
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp return func(*args, **kwargs)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/conductor/manager.py", line 331, in action_event_start
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp evt = self.db.action_event_start(context, values)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/db/api.py", line 1637, in action_event_start
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp return IMPL.action_event_start(context, values)
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/nova/db/sqlalchemy/api.py", line 4556, in action_event_start
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp instance_uuid=values['instance_uuid'])
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp InstanceActionNotFound: Action for request_id req-1d8a3942-3f64-40fd-829f-4832d83c56fb on instance af217dbd-286e-47f9-aed7-0b9389bda5c4 not found
2013-03-05 10:28:57.803 21673 TRACE nova.openstack.common.rpc.amqp
2013-03-05 10:28:57.805 ERROR nova.openstack.common.rpc.common [req-1d8a3942-3f64-40fd-829f-4832d83c56fb 649f11019c074251a512e8275ff333dc c8d62a65698f4398ba3d3c458aceb0ad] Returning exception Action for request_id req-1d8a3942-3f64-40fd-829f-4832d83c56fb on instance af217dbd-286e-47f9-aed7-0b9389bda5c4 not found to caller

-----

The issue seems to be that when doing a delete on a resized instance Nova automatically does the resize revert/confirm for you... but we are missing an extra instance_action_start in that case.

Dan Prince (dan-prince) on 2013-03-05

Changed in nova:
assignee:	nobody → Dan Prince (dan-prince)
importance:	Undecided → High
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-05: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23583

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-07: Fix merged to nova (master)

Reviewed: https://review.openstack.org/23583
Committed: http://github.com/openstack/nova/commit/4e118a45e7cce335efe9d1286eac4f6c8bd69e4d
Submitter: Jenkins
Branch: master

commit 4e118a45e7cce335efe9d1286eac4f6c8bd69e4d
Author: Dan Prince <email address hidden>
Date: Tue Mar 5 12:59:11 2013 -0500

Add missing action_start if deleting resized inst.

    When trying to delete a resized instance Nova will automatically
    call confirm on the resized instance to help clean things
    up. With some of the recent action event changes in grizzly this
    code path was broken due to a missing record_action_start
    call on the confirm_resize operation.

Fixes LP Bug #1147387.

Change-Id: I23e84de8675c980656a71b71e34ffa0a0801f389