Templates are not django 1.5 compatible

Bug #1147329 reported by Matthias Runge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Lin Hua Cheng

Bug Description

https://docs.djangoproject.com/en/1.5/releases/1.5/#overview lists to change url tags in templates:
{% url myview %} to {% url "myview" %}

That should be django-1.4 safe also.

Revision history for this message
Matthias Runge (mrunge) wrote :

other changes are: simplejson is now used from system and dropped from Django

Changed in horizon:
assignee: nobody → Matthias Runge (mrunge)
assignee: Matthias Runge (mrunge) → nobody
Revision history for this message
Matthias Runge (mrunge) wrote :

to be changed: openstack_dashboard/dashboards/project/network_topology/views.py:import simplejson

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

We'll address Django 1.5 first thing in Havana.

Changed in horizon:
importance: Undecided → High
milestone: none → havana-1
status: New → Confirmed
Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

Looks like ALLOWED_HOSTS needs to be added for production settings.

https://docs.djangoproject.com/en/1.5/releases/1.5/#allowed-hosts-required-in-production

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/25574

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/25574
Committed: http://github.com/openstack/horizon/commit/5d32caf3af3b11fcf496ebb04ccfc44f49cbe0b9
Submitter: Jenkins
Branch: master

commit 5d32caf3af3b11fcf496ebb04ccfc44f49cbe0b9
Author: Lin Hua Cheng <email address hidden>
Date: Wed Mar 27 17:16:13 2013 -0700

    Update Horizon for Django 1.5 compatibility

    Changes made:
    - Changed template url tags: {% url myview %} to {% url myview %}
    - Import json instead of django.utils.simplejson
    - Import django.utils.encoding.force_unicode instead of
      django.utils.translation.force_unicode
    - Fixed error in tables/base.py for CheckboxInput, pass a callable
      check_test. Django 1.5 does not silently fail on this now.
    - Set SECRET_KEY in test/settingspy, Django 1.5 refuse to start if it
      is not set.
    - Added notes about ALLOWED_HOSTS when running Horizon in Production

    Fixes bug 1147329

    Change-Id: I6ac1e81498f41141dea99760922991feb310a326

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.