Return 501 for not implemented action

[Alex Xu]

We haven't conistent return code for non-implemented action.

QuotaSetsController.create returns 500
AgentPluginBase.create_agent returns 404
ExtensionController.delete/create return 404
NetworkSchedulerController.update/show return 500
RouterSchedulerController.update/show return 500
DhcpAgentsHostingNetworkController.create/delete/update/show return 500
L3AgentsHostingRouterController.create/delete/update/show return 500

As discusstion at https://review.openstack.org/#/c/23406/5/quantum/extensions/quotasv2.py

We prefer use 501 for this case

[Nachi Ueno (nati-ueno)]

We need to discuss this quickly, because this is the API change.
I prefer we should use 501 for this case.

[Sumit Naiksatam (snaiksat)]

Agree, ideally this should be consistent and 501 seems like the right choice.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23664

[Salvatore Orlando (salvatore-orlando)]

I wonder for which reason API changes came up always in RC period.
Usually anything that we quickly discuss and decide never ends up well :)

I am happy with raising a 501.
I am nervous about the proposed change that potentially affects all existing extensions.

[dan wendlandt (danwent)]

Yeah, I think we should shut down all of these "nice to have" API changes.

dan

On Wed, Mar 6, 2013 at 6:46 AM, Salvatore Orlando <
<email address hidden>> wrote:

> I wonder for which reason API changes came up always in RC period.
> Usually anything that we quickly discuss and decide never ends up well :)
>
> I am happy with raising a 501.
> I am nervous about the proposed change that potentially affects all
> existing extensions.
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/1146586
>
> Title:
> Return 501 for not implemented action
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> We haven't conistent return code for non-implemented action.
>
> QuotaSetsController.create returns 500
> AgentPluginBase.create_agent returns 404
> ExtensionController.delete/create return 404
> NetworkSchedulerController.update/show return 500
> RouterSchedulerController.update/show return 500
> DhcpAgentsHostingNetworkController.create/delete/update/show return 500
> L3AgentsHostingRouterController.create/delete/update/show return 500
>
> As discusstion at
> https://review.openstack.org/#/c/23406/5/quantum/extensions/quotasv2.py
>
> We prefer use 501 for this case
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1146586/+subscriptions
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~

[Justin Hammond (justin-hammond)]

Is this still a viable bug? I have time and I want to fix whatever I can.

[Armando Migliaccio (armando-migliaccio)]

You might want to have a look at bug 1197200, because a few of them might have already been fixed (most likely the ones that return 500)

[Justin Hammond (justin-hammond)]

I will look to see if this is still happening.

[Armando Migliaccio (armando-migliaccio)]

This bug is > 240 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]