N802 rule has limit of 72 characters but prints 50 as limit

Bug #1144840 reported by Steven Dake
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Steven Dake

Bug Description

The N082 rule checks for 72 characters as the maximum summary length, however, the pep output indicates the commit summary should be less then 50 characters. At some point, I expect someone modified the code to match the workflow via jenkins rather then the typical git mailing list approach of mailing a message to a mailing list.

Steven Dake (sdake)
Changed in nova:
assignee: nobody → Steven Dake (sdake)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23440

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23440
Committed: http://github.com/openstack/nova/commit/4ac268a4b620eecc4af1f4ffdc0a836d7260d126
Submitter: Jenkins
Branch: master

commit 4ac268a4b620eecc4af1f4ffdc0a836d7260d126
Author: Steven Dake <email address hidden>
Date: Mon Mar 4 10:31:10 2013 -0700

    docs should indicate proper git commit limit

    The nova gate should recommend 50 characters or less for a git commit
    but actually enforce 72 characters.

    This patch changes the hacking.rst docs to indicate the actual limit
    is 72 characters rather then 50 characters.

    Change-Id: I47f1f1f1007f5744bf1fef419df7e033803b4a53
    Fixes: Bug #1144840

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.