Cannot delete snapshot in "error" state

[Anil Benny]

Not able to delete volume( Error state) created from a snapshot of mismatched size. Also if the snapshot is in error state cannot delete it.

stack@stlrx300s7-30:~$ cinder create --snapshot-id 0f71b1d7-89eb-462c-8d30-8f32f4c8dcb4 1
+---------------------+--------------------------------------+
| Property | Value |
+---------------------+--------------------------------------+
| attachments | [] |
| availability_zone | nova |
| bootable | false |
| created_at | 2013-03-04T06:04:22.156440 |
| display_description | None |
| display_name | None |
| id | 054264c2-4fe4-4dd8-a897-f9dc967f5acc |
| metadata | {} |
| size | 1 |
| snapshot_id | 0f71b1d7-89eb-462c-8d30-8f32f4c8dcb4 |
| source_volid | None |
| status | creating |
| volume_type | None |
+---------------------+--------------------------------------+
stack@stlrx300s7-30:~$ cinder list
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
| ID | Status | Display Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+-----------+--------------+------+-------------+----------+-------------+
| 054264c2-4fe4-4dd8-a897-f9dc967f5acc | error | None | 1 | None | false | |

stack@stlrx300s7-30:~$ cinder delete 054264c2-4fe4-4dd8-a897-f9dc967f5acc
stack@stlrx300s7-30:~$ cinder list
+--------------------------------------+----------------+--------------+------+-------------+----------+-------------+
| ID | Status | Display Name | Size | Volume Type | Bootable | Attached to |
+--------------------------------------+----------------+--------------+------+-------------+----------+-------------+
| 054264c2-4fe4-4dd8-a897-f9dc967f5acc | error_deleting | None | 1 | None | false | |

2013-03-04 01:04:44.610 WARNING cinder.volume.drivers.netapp.iscsi [req-9cf4460a-edbe-4594-ade6-1857774649e8 f4ea6976293e462d9efd8aaa4afc4652 6124097ebdfe4273a716d3f74179ad4c] Could not find attribute for LUN named volume-054264c2-4fe4-4dd8-a897-f9dc967f5acc
2013-03-04 01:04:44.647 ERROR cinder.openstack.common.rpc.amqp [-] Exception during message handling
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp Traceback (most recent call last):
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp File "/opt/stack/cinder/cinder/openstack/common/rpc/amqp.py", line 275, in _process_data
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp File "/opt/stack/cinder/cinder/openstack/common/rpc/dispatcher.py", line 145, in dispatch
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp File "/opt/stack/cinder/cinder/volume/manager.py", line 420, in delete_volume
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp {'status': 'error_deleting'})
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp self.gen.next()
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp File "/opt/stack/cinder/cinder/volume/manager.py", line 409, in delete_volume
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp self.driver.delete_volume(volume_ref)
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp File "/opt/stack/cinder/cinder/volume/drivers/netapp/iscsi.py", line 1576, in delete_volume
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp **{'path': metadata['Path'],
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp TypeError: 'NoneType' object has no attribute '__getitem__'
2013-03-04 01:04:44.647 TRACE cinder.openstack.common.rpc.amqp
2013-03-04 01:04:57.446 INFO cinder.volume.manager [-] Updating volume status

[Anil Benny (anil-benny)]

Please refer the bug fix https://bugs.launchpad.net/cinder/+bug/1090167 which is made for the Volume ( which is in error state ) and after its deleted it goes in error_deleting. Just wanted to make sure all NetApp drivers are fixed with this issue along with the snapshot error_deleting issue. Please provide the same logic across all drivers while you have a fix. Thanks!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23526

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23526
Committed: http://github.com/openstack/cinder/commit/d595d344016719eab810628a62bd276b9e98ea91
Submitter: Jenkins
Branch: master

commit d595d344016719eab810628a62bd276b9e98ea91
Author: Navneet Singh <email address hidden>
Date: Sat Feb 16 02:30:26 2013 -0800

    NetApp: Fix for snapshot not deleted in error state.

    This fix enables cleaning of volumes/snapshots
    in error state by allowing them to delete.
    It will allow the delete call to be
    successful if snapshot/volume are in
    error state. This also fixes the bug
    raised recently with number 1145409 which seems
    to be duplicate of 1143661.

    bug 1143661
    bug 1145409

    Change-Id: I38bc13e676404f96db54b12edfa56680489e893e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/24295

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/24883

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24883
Committed: http://github.com/openstack/cinder/commit/00e8049cbec550a0342054a02fc3ea35be25dad0
Submitter: Jenkins
Branch: stable/folsom

commit 00e8049cbec550a0342054a02fc3ea35be25dad0
Author: Rushi Agrawal <email address hidden>
Date: Tue Mar 12 01:39:44 2013 +0530

    NetApp[backport]: Fix for snapshot not deleted in error state.

    This fix enables cleaning of volumes/snapshots
    in error state by allowing them to delete.
    It will allow the delete call to be
    successful if snapshot/volume are in
    error state. This also fixes the bug
    raised recently with number 1145409 which seems
    to be duplicate of 1143661.

    bug 1143661
    bug 1145409

    Change-Id: I38bc13e676404f96db54b12edfa56680489e893e