bdm dict item read as attribute in snapshot_volume_backed
Bug #1142734 reported by
Hans Lindgren
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Hans Lindgren |
Bug Description
Stumbled upon an error similar to the one found in
https:/
item is tried to be read as an attribute.
if bdm.no_device:
should be replaced with
if bdm['no_device']:
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
milestone: | none → grizzly-rc1 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | grizzly-rc1 → 2013.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/23376 github. com/openstack/ nova/commit/ 4a2c57684c18f90 f23263156f95256 1154751e09
Committed: http://
Submitter: Jenkins
Branch: master
commit 4a2c57684c18f90 f23263156f95256 1154751e09
Author: Hans Lindgren <email address hidden>
Date: Sun Mar 3 16:19:08 2013 +0100
Fix an error in compute api snapshot_ volume_ backed bdm code
Stumbled upon an error similar to the one found in /review. openstack. org/#/c/ 23354/ where a dbm dict
https:/
item is tried to be read as an attribute.
Looked at the next couple of lines and discovered more
cases of this error.
Updates to some api tests that contain faulty fakes that
hide this error adds some coverage for this error. Rebased
this patch on the above mentioned review to be able to
change the tests, since the code path is the same and they
now hit both of these errors.
Resolves bug 1142734.
Change-Id: Ie639cd483334b6 222085a139159da 47ce6fa3671