nova-manage --version doesn't return anything

[Joe Gordon]

From Latest Develop (Grizzly RC3)

$ nova-manage --version
$

$ nova-manage version
2013.1
$

[Chuck Short (zulcss)]

Is this a regression?

[Davanum Srinivas (DIMS) (dims-v)]

@markmc,

1) For "--version" to work is for us to pass in version string in nova/config.py when we call cfg.CONF()
2) To get the version string we need to call version_string_with_package() in nova/version.py

#2 assumes that config-dir, config-file, project options are set because it is calling find_file in cfg.py which is done in #1 (cfg.CONF() is called with project, version etc). So there seems to be a cyclical problem.

Thoughts please?

-- dims

[Joe Gordon (jogo)]

'nova-manage version' works

just not 'nova-manage --version'

vagrant@precise64:~$ nova-manage version
2013.1
vagrant@precise64:~$ nova-manage --version
vagrant@precise64:~$

[Davanum Srinivas (DIMS) (dims-v)]

@markmc,

The only solution i could come up with with least changes to oslo-config and nova is this:

http://paste.openstack.org/show/32974/

-- dims

[Davanum Srinivas (DIMS) (dims-v)]

Shows up in other projects as well

https://bugs.launchpad.net/keystone/+bug/1152740

[Michael Still (mikal)]

@dims -- I recon you should send off that paste as a code review.

[Davanum Srinivas (DIMS) (dims-v)]

I have some changes for oslo in https://review.openstack.org/#/c/24076/ - if that gets approved, then i'll submit the nova changes needed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24173

[Mark McLoughlin (markmc)]

I proposed a simple patch to Nova that seems to work fine

dims: not sure why you wanted to use version_string_with_package() rather than simply version_string() ?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24173
Committed: http://github.com/openstack/nova/commit/01627ff0bf522deb8c2a838724f88cd2506ca626
Submitter: Jenkins
Branch: master

commit 01627ff0bf522deb8c2a838724f88cd2506ca626
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 12 13:02:09 2013 +0000

    Fix nova-manage --version

    Fixes bug #1138844

    Pass the version kwarg to cfg.CONF() so that --version shows the
    version number.

    Change-Id: I589ebffec67ef00f8ba24f553bf3e81806aa50b6