OpenStack Compute (nova)

remove pylint errors in security_group_base

Bug #1138269 reported by Aaron Rosen on 2013-03-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Aaron Rosen	OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

nova/network/security_group/security_group_base.py:139: [E1101, SecurityGroupBase.create_security_group_rule] Instance of 'SecurityGroupBase' has no 'raise_group_already_exists' member

Aaron Rosen (arosen) on 2013-03-01

Changed in nova:
assignee:	nobody → Aaron Rosen (arosen)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-01: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23312

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-03-02: Fix merged to nova (master)

Reviewed: https://review.openstack.org/23312
Committed: http://github.com/openstack/nova/commit/35b2b2c5c456c3138e0e31085c71d852320b9ce4
Submitter: Jenkins
Branch: master

commit 35b2b2c5c456c3138e0e31085c71d852320b9ce4
Author: Aaron Rosen <email address hidden>
Date: Fri Mar 1 10:23:01 2013 -0800

Remove pylint errors for undefined GroupException members

    Pylint complains about 'SecurityGroupBase' has no 'raise_group_already_exists'
    member as these methods are called from SecurityGroupBase but do not exist in
    this class. This is fine as this class is not invoked directly. This patch
    adds these prototypes which raise NotImplementedError and changes the
    inheritance order as to not raise NotImplementedError.

Fixes bug 1138269

Change-Id: I2d7b723a482dc8ca845e52e2a8f44c6fd31fa5db