incorrect pathname assert in test_config.py

Bug #1138216 reported by Baodong (Robert) Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Baodong (Robert) Li

Bug Description

Depending on how the working directory is set up in nose, the following assert in ./quantum/tests/unit/test_config.py may fail .
        self.assertEqual(os.path.abspath('../../..'),
                         cfg.CONF.state_path)

For example, if the working dir was /opt/stack/quantum/tests, the call to os.path.abspath('../../..') would return /opt/stack, while cfg.CONF.state_path is /opt/stack/quantum. Thus the assert would fail.

Changed in quantum:
assignee: nobody → Baodong (Robert) Li (baoli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23313

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/23313
Committed: http://github.com/openstack/quantum/commit/a4d41a38ccb39a7d218fc46d84e7a9753af067f5
Submitter: Jenkins
Branch: master

commit a4d41a38ccb39a7d218fc46d84e7a9753af067f5
Author: Baodong (Robert) Li <email address hidden>
Date: Fri Mar 1 10:02:12 2013 -0800

    fix incorrect pathname

    return of call to os.path.abspath('../../..') depends on the setup of
    nose working directory. Change to return the directory where
    test_config.py resides

    fixes: bug #1138216
    Change-Id: I1d3f1e3c88bd30871a018a195cee46a91d35c8a8

Changed in quantum:
status: In Progress → Fix Committed
Changed in quantum:
milestone: none → grizzly-rc1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.