Improve output of _compare_result in case of errors

Bug #1133621 reported by Giampaolo Lauria
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Giampaolo Lauria

Bug Description

In case of errors, _compare_result throws an exception which will display the results of "expected" and "results".

I think it would be easier to debug its output if:
1) We specify where the output is coming from (template or response)
2) Whether we are referring to a list or dictionary
3) In case of key mismatch for a dictionary, only display those keys in the dictionary which differ from one another, not the entire list of keys. The longer the lists, the harder it becomes to figure out which items differ.

Changed in nova:
assignee: nobody → Giampaolo Lauria (lauria)
description: updated
Changed in nova:
importance: Undecided → Low
Changed in nova:
status: New → Confirmed
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23039

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/23063

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/23039
Committed: http://github.com/openstack/nova/commit/cd9e5c94f7388489daf38d0e6753af2208b14b79
Submitter: Jenkins
Branch: master

commit cd9e5c94f7388489daf38d0e6753af2208b14b79
Author: Giampaolo Lauria <email address hidden>
Date: Tue Feb 26 22:41:17 2013 -0500

    Improve output msgs for _compare_result

    In case of errors, the messages are now more detailed.
    Fixes bug 1133621

    Change-Id: I7747d7c4dcaf2199dc55139ee0235f6adca1ad36

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.