Region switcher does not pre-select the Region when there is a special character

Bug #1133048 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Lin Hua Cheng

Bug Description

The region is not pre-selected in the pop-up opened by the region switcher.

The issue occurs if there is a special character in the region name.

Existing code:
  <a class="ajax-modal" href="{% url login %}?region={{ region.endpoint }}">{{ region.name }}</a>

Suggested fix, add urlencode filter:
  <a class="ajax-modal" href="{% url login %}?region={{ region.endpoint|urlencode }}">{{ region.name }}</a>

Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23004

Changed in horizon:
status: New → In Progress
Changed in horizon:
milestone: none → grizzly-rc1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/23004
Committed: http://github.com/openstack/horizon/commit/85157a7cb544a9ae8106132d6037d5055defbe9a
Submitter: Jenkins
Branch: master

commit 85157a7cb544a9ae8106132d6037d5055defbe9a
Author: Lin Hua Cheng <email address hidden>
Date: Tue Feb 26 10:36:57 2013 -0800

    Escape the region name before passing as value in URL.

    Fixes bug 1133048.

    Change-Id: I03f7eb0df9f5ae46b6b41da76e0486663403e357

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.