Latest jsonschema release breaks unit tests

Bug #1132840 reported by Matthew Treinish
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Matthew Treinish
Grizzly
Fix Released
High
Matthew Treinish

Bug Description

jsonschema v1.0.0 was release on 02/25/2013 this update breaks the unit tests with a failure like:

ft50.1: glance.tests.unit.v2.test_images_resource.TestImagesDeserializerWithExtendedSchema.test_create_StringException: Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-glance-python27/glance/tests/unit/v2/test_images_resource.py", line 1237, in test_create
    output = self.deserializer.create(request)
  File "/home/jenkins/workspace/gate-glance-python27/glance/api/v2/images.py", line 206, in create
    self.schema.validate(body)
  File "/home/jenkins/workspace/gate-glance-python27/glance/schema.py", line 32, in validate
    jsonschema.validate(obj, self.raw())
  File "/home/jenkins/workspace/gate-glance-python27/.tox/py27/local/lib/python2.7/site-packages/jsonschema.py", line 1239, in validate
    cls.check_schema(schema)
  File "/home/jenkins/workspace/gate-glance-python27/.tox/py27/local/lib/python2.7/site-packages/jsonschema.py", line 141, in check_schema
    error.message, validator=error.validator, path=error.path,
SchemaError: True is not of type u'array'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22862

Changed in glance:
assignee: nobody → Matthew Treinish (treinish)
status: New → In Progress
Revision history for this message
Flavio Percoco (flaper87) wrote :

This should be backported to stable/folsom as well.

Thanks for reporting and fixing!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/22879

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/22862
Committed: http://github.com/openstack/glance/commit/c48d59690c231f9f2362844df55ece7fe720a8fa
Submitter: Jenkins
Branch: master

commit c48d59690c231f9f2362844df55ece7fe720a8fa
Author: Matthew Treinish <email address hidden>
Date: Mon Feb 25 10:37:01 2013 -0500

    Pin jsonschema version below 1.0.0.

    The latest jsonschema version breaks the unit tests. This commit pins
    the version to be less than the latest release.

    Fixes bug 1132840

    Change-Id: Ib4db4782f995cee179445ca11d2b6a7f13a6b457

Changed in glance:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → High
milestone: none → grizzly-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/23281

Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.