autosave file is overwritten on restart

[James Troup]

Binary package hint: sobby

sobby helpfully saves state to an autosave file. so far so good. unfortunately, unless you specify the autosave file as an argument when starting sobby, it will not restore from it but instead completely wipe out the autosave file, starting again from scratch. even more unfortunately, the init script doesn't use the autosave file as an argument, so in it's default setup the autosave file will get wiped out whenever the daemon is restarted (e.g. on machine reboot or gobby crash). Which kind of defeats the whole point of the autosave file...

[Stijn Polfliet (stijn-polfliet)]

I will look at this bug, with dedicated support of my mentor: Emmet Hikory.

[Stijn Polfliet (stijn-polfliet)]

Hello,

I successfully installed the patch for schroot, much easier now.
I reconfigured schroot with the script from the howto, still the same
result while running gnome-hearts in chroot. Anyway we'll check that
'bug' later...

I've taken a look at the code for sobby but it will need some more
time to find out how to solve the problem. It also has been a while
since I've seen C++ code, but I certainly won't give up.

I have a busy day tomorrow and another one Friday. I should also study
a little bit, so I probably won't be able to immediately solve the bug
;-)
When I have a some time I will certainly explore the code and contact you.

Bye!

Stijn

Ps: gnome-hearts was already build successfully on some architectures

On 5/23/07, Emmet Hikory <email address hidden> wrote:
> ** Changed in: sobby (Ubuntu)
> Importance: Undecided => Medium
>
> --
> autosave file is overwritten on restart
> https://bugs.launchpad.net/bugs/113279
> You received this bug notification because you are a bug assignee.
>

[Stijn Polfliet (stijn-polfliet)]

This is a patch that checks on startup/restart/reboot whether there is a autosave file or not. If there is one, a backup of the previous autosave file will be made.

[Benjamin (enjamin-gobby-bugs)]

Apparently the issue originates from the init script naming the same autosave file over and over again.

Would it not be more elegant to change the init script so that it either
- loads the previous autosave file so that the previous session is continued (and autosaved into the same file)
or
- comes up with another autosave file name if the given one is already taken (much like your patch does, but outside sobby)?

I am not sure whether this adequately addresses your concerns, but it seems to me that either would be a simpler solution.

[anonymous (anonymous-gobby-bugs)]

This patch only makes sure that there isn't a previous autosave file overwritten, which can help people who are encountering the same problem.
The developers should concern, as you suggest, to change the sobby package so it does what everyone expects it would do: automatically reload the previous autosave file. I must say that it does seem like a better solution...

Replying to [comment:1 Benjamin Herr]:
> Apparently the issue originates from the init script naming the same autosave file over and over again.
>
> Would it not be more elegant to change the init script so that it either
> - loads the previous autosave file so that the previous session is continued (and autosaved into the same file)
> or
> - comes up with another autosave file name if the given one is already taken (much like your patch does, but outside sobby)?
>
> I am not sure whether this adequately addresses your concerns, but it seems to me that either would be a simpler solution.

[Henrik Nilsen Omma (henrik)]

James, does this solve the problem in an appropriate way? If so we should send it upstream. It would be nice combine this with #114023 for an SRU in Feisty.

[Stijn Polfliet (stijn-polfliet)]

This bug is filed upstream: http://gobby.0x539.de/trac/ticket/268.
Maybe you could check it out?
Thanks

[armin (armin-gobby-bugs)]

Sobby 0.4.4 has a new option in the config file called "session" that specifies a session file to load when starting sobby. Sobby will also start if that file does not exist. You may set it to the same value as the "autosave_file" config option to reload a previously saved session before overwriting it. Does this solve this issue for you?

[Joey Stanford (joey)]

The upstream bug has this as a possible closing:

"Sobby 0.4.4 has a new option in the config file called "session" that specifies a session file to load when starting sobby. Sobby will also start if that file does not exist. You may set it to the same value as the "autosave_file" config option to reload a previously saved session before overwriting it. Does this solve this issue for you?"

[Philipp Kern (pkern)]

Joey, the fix you state was just synced into universe. I disagree with the patch "fixing" the problem by backing up the previous autosave file. It should be loaded as a session file instead.

[Philipp Kern (pkern)]

Sorry to say, but the fix submitted by Stijn Polfliet was rejected upstream. Gutsy now contains a version of Sobby which allows to specify the session file to load in the configuration file (even if it is not already present). The solution is thus to specify a file both as session file and autosave file.

[launchpad (launchpad-gobby-bugs)]

Updating Launchpad bug reference