Every page is making an XMLHttpRequest every few seconds

[Kieran Spear]

Every page is making an XHR to itself at the moment. Firebug tells me it is happening here:

horizon.networktopology.js

  init:function(){
    var self = this;
    $("#topologyCanvas").spin(horizon.conf.spinner_options.modal);
    self.retrieve_network_info();
    setInterval(horizon.network_topology.retrieve_network_info,
               horizon.network_topology.reload_duration);
  },
  retrieve_network_info: function(){
    var self = this;
    if(!$("#networktopology")) {
        return;
    }
    $.getJSON($("#networktopology").data('networktopology'), <--- this is running on every page
      function(data) {
        self.draw_graph(data);
      }
    );
  },

[Gabriel Hurley (gabriel-hurley)]

Bah. Good catch. Definitely needs to be fixed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23105

[Julie Pichon (jpichon)]

Ah, I see. This will also fix the extra UnexpectedMethodCallError traces that are appearing in the Selenium test outputs.

e.g.
http://logs.openstack.org/21916/16/gate/gate-horizon-selenium/1079/console.html.gz
http://logs.openstack.org/23004/1/gate/gate-horizon-selenium/1183/console.html.gz

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23105
Committed: http://github.com/openstack/horizon/commit/b5f4d63c7ca3f1dec87aa7fec1110e0bdc579e2b
Submitter: Jenkins
Branch: master

commit b5f4d63c7ca3f1dec87aa7fec1110e0bdc579e2b
Author: David Lyle <email address hidden>
Date: Wed Feb 27 11:27:33 2013 -0700

    Fix errant XHR request happening on every page

    The check of the jquery selector by name will always return a
    non-null object even if the object does not exist on the page,
    the check needs to make sure the object returned doesn't
    contain any items.

    Change-Id: I51367547a37a2ee72ed300853d35d3cc6d89df7d
    Fixes: bug #1132588