Filtering the results from an api call by boolean doesn't work

Bug #1132372 reported by Henry Nash
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Henry Nash

Bug Description

The current filtering mechanism on the results of an api call (e.g. GET /users) doesn't work for booleans, since we are not allowing for the mismatch of string vs boolean types (i.e. the filter attribute will come across as a string). Sample api that fails:

GET /domains?enabled=0

Specifying any boolean filter will result in no results being returned currently.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22789

Changed in keystone:
status: New → In Progress
Henry Nash (henry-nash)
summary: - Filtering the results from an api call by boolean does work
+ Filtering the results from an api call by boolean doesn't work
Dolph Mathews (dolph)
Changed in keystone:
importance: High → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/22789
Committed: http://github.com/openstack/keystone/commit/b4adb6a56fd1e03bfccd542f99634975ef6ac138
Submitter: Jenkins
Branch: master

commit b4adb6a56fd1e03bfccd542f99634975ef6ac138
Author: Henry Nash <email address hidden>
Date: Sun Feb 24 08:34:07 2013 +0000

    Improve tests for api protection and filtering

    Fills out some more tests for both these areas. To make it easier for
    any v3 tests to do their own authentication, moved the auth builder
    utility functions from test_v3_auth into test_v3.RestfulTestCase.

    Also fixed an issue that meant the api filtering on a boolean
    would not work.

    Fixes Bug #1132080
    Fixes Bug #1132372

    Change-Id: I7bb7b5ba61adfc6a9c496a5547a0ca3fcfbab209

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.