v2 api should ensure important properties are set prior to upload

Bug #1131994 reported by Mark Washenberger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Critical
Mark Washenberger
Grizzly
Fix Released
Critical
Mark Washenberger

Bug Description

The v1 api ensures that certain image metadata properties are set prior to allowing image activation.

We should make sure v2 supports this behavior too. In particular, the attributes I see being enforced are 'container_format', 'disk_format', and 'name'.

Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Critical
milestone: none → grizzly-rc1
Brian Waldon (bcwaldon)
Changed in glance:
assignee: nobody → Mark Washenberger (markwash)
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23043

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/23043
Committed: http://github.com/openstack/glance/commit/d6bad9149312937159ae94d6008e25a48c004fa2
Submitter: Jenkins
Branch: master

commit d6bad9149312937159ae94d6008e25a48c004fa2
Author: Mark J. Washenberger <email address hidden>
Date: Tue Feb 26 14:16:01 2013 -0800

    Ensure disk_ and container_format during upload

    This patch changes the image domain model so that the transition from
    'queued' to 'saving' or 'active' status cannot take place if the image's
    disk_format or container_format are not set.

    Fixes bug 1131994

    Change-Id: I454d9df736edd771f9d5d93eca4cd317116cc985

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.