ec2 _format_security_group() access db using quantum_driver

[Aaron Rosen]

Also, there are no unit tests for the ec2 api when using quantum as the security group driver. I'll add tests with this bug fix.

2013-02-22 02:28:49.151 DEBUG nova.api.ec2 [req-e346566f-ade0-4400-9863-fb9a3ebcb330 demo demo] action: DescribeSecurityGroups __call__ /opt/stack/new/nova/nova/api/ec2/__init__.py:334
2013-02-22 02:28:49.208 ERROR nova.api.ec2 [req-e346566f-ade0-4400-9863-fb9a3ebcb330 demo demo] Unexpected error raised: 'grantee_group'
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 Traceback (most recent call last):
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 File "/opt/stack/new/nova/nova/api/ec2/__init__.py", line 481, in __call__
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 result = api_request.invoke(context)
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 File "/opt/stack/new/nova/nova/api/ec2/apirequest.py", line 79, in invoke
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 result = method(context, **args)
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 File "/opt/stack/new/nova/nova/api/ec2/cloud.py", line 489, in describe_security_groups
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 groups = [self._format_security_group(context, g) for g in raw_groups]
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 File "/opt/stack/new/nova/nova/api/ec2/cloud.py", line 506, in _format_security_group
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 source_group = rule['grantee_group']
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2 KeyError: 'grantee_group'
2013-02-22 02:28:49.208 19263 TRACE nova.api.ec2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/22757

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/22757
Committed: http://github.com/openstack/nova/commit/0bc531254cb964556cbe8d2fbf1f9321f92aaf93
Submitter: Jenkins
Branch: master

commit 0bc531254cb964556cbe8d2fbf1f9321f92aaf93
Author: Aaron Rosen <email address hidden>
Date: Mon Feb 25 15:03:20 2013 -0800

    ec2 _format_security_group() accesses db when using quantum_driver

    This patch fixes _format_security_group() so that it does not
    access the db when using quantum. In addition, this patch implements
    the querying params that were missing in get() and list() in the quantum
    security group driver.

    Fixes bug 1131956

    Change-Id: I5ec65829301bca7e5b215d5052a18528dff76517