OpenStack Identity (keystone)

v3_protection test leaves CONF.policyfile setting in incorrect state

Bug #1131819 reported by Henry Nash on 2013-02-22

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Identity (keystone)	Fix Released	High	Henry Nash	OpenStack Identity (keystone) 2013.1 "grizzly"

Bug Description

Any test that resets the policy file name is in danger of affecting subsequent tests. Both test_policy and test_v3_protection do this. The should reset the policy file name in teardown

Henry Nash (henry-nash) on 2013-02-22

Changed in keystone:
importance:	Undecided → High
assignee:	nobody → Henry Nash (henry-nash)
milestone:	none → grizzly-rc1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-02-22: Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22705

Changed in keystone:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-02-25: Fix merged to keystone (master)

Reviewed: https://review.openstack.org/22705
Committed: http://github.com/openstack/keystone/commit/1f7f1bd3c846da88269c0c05a4f20ed4a514e063
Submitter: Jenkins
Branch: master

commit 1f7f1bd3c846da88269c0c05a4f20ed4a514e063
Author: Henry Nash <email address hidden>
Date: Fri Feb 22 16:30:35 2013 +0000

Ensure keystone unittests do not leave CONF.policyfile in bad state

    A few of the tests overwrite the name of the policy file (so they can
    use a temp file instead). However, if it is left that way, subsequent
    tests that rely on it may fail.

    A separate patch will look at doing a more comprehensive reset in the
    setup of test_v3 - ensuring we always start from a completely clean
    slate for all confirguration parameters.

Fixes Bug #1131819

Change-Id: Ibe5ee12f44310de00b12ddd405c83f59b2d840b7