Use API unit tests requests on all backends

Bug #1131638 reported by Julien Danjou
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Unassigned

Bug Description

Currently, the API unit tests are run on a ceilometer.storage.impl_test which is based on MIM. We need to change that somehow so we have all of our APIs test ran against other implementation like SQLAlchemy.

Julien Danjou (jdanjou)
Changed in ceilometer:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Do we? It seems like if we have tests verifying that all of the backends behave the same way, then we don't need to run the API tests against all of the backends.

Revision history for this message
Julien Danjou (jdanjou) wrote :

It would really be a good idea. There's no check nor conversion between what's returned by the storage backend and what's return though the API, so we can have some driver returning valid Python values but not valid for WSME. This already happened twice with bug #1132628 and an older one.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

I agree there's a problem with the database API, I'm just not certain fixing it requires making the test suite run take so much longer. For example, I've opened a blueprint to define database models for the storage API (https://blueprints.launchpad.net/ceilometer/+spec/storage-api-models).

Revision history for this message
Julien Danjou (jdanjou) wrote :

I wouldn't disagree with such a solution Doug. I just prefer to "fix" or possibly detect failure of our current existing code first, and that just requires us to enable more tests. :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/23302
Committed: http://github.com/openstack/ceilometer/commit/c41249e488c553c3cbd69fa54873fb4ebcaf86f1
Submitter: Jenkins
Branch: master

commit c41249e488c553c3cbd69fa54873fb4ebcaf86f1
Author: Julien Danjou <email address hidden>
Date: Fri Mar 1 18:09:11 2013 +0100

    Run some APIv1 tests on different backends

    This is a first change towards implementing bug #1131638. It clears a lot of
    stuff in the various DB mocking stuff, and I plan to do more after.

    In the same process, this implements a unit test and a fix for bug #1138137

    Change-Id: I36a6741393455c764913e0388d73d834db06da8c
    Signed-off-by: Julien Danjou <email address hidden>

Changed in ceilometer:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.