OpenStack Identity (keystone)

LDAP scoped queries breaks object creation

Bug #1131265 reported by Adam Young
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Critical
Adam Young
OpenStack Identity (keystone) 2013.1 "grizzly"

Bug Description

This commit:

https://github.com/openstack/keystone/commit/159ffe48e986e524f5930ad41d376bdce2b6a07e

changed how object ids are created to do a lookup. However, if the object does not yet exist, it throws an exception, which breaks object creation. This should have been caught in the unit tests, but the unit tests modify the code back to the origianl logic, so the new logic was never tested.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22561

Changed in keystone:
status: New → In Progress
Adam Young (ayoung)
Changed in keystone:
importance: Undecided → Critical
assignee: nobody → Adam Young (ayoung)
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → grizzly-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/22561
Committed: http://github.com/openstack/keystone/commit/573437511f741cdd9163aefec028894354756365
Submitter: Jenkins
Branch: master

commit 573437511f741cdd9163aefec028894354756365
Author: Adam Young <email address hidden>
Date: Thu Feb 21 11:09:57 2013 -0500

    Fix id_to_dn for creating objects

    Only do the lookup if the scope is not ONELEVEL
    For ONELEVEL, there is no point in paying the price of the lookup.

    If the object is not found for scoped queries, return the top level
    DN so the object can be created.

    Bug 1131265

    Change-Id: I1ca41bf87c3bdea30fbdf607b19192f37dd0bfd6

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/22620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (milestone-proposed)

Reviewed: https://review.openstack.org/22620
Committed: http://github.com/openstack/keystone/commit/a4086ac93f0b894977cbb6a3768e9335a613a602
Submitter: Jenkins
Branch: milestone-proposed

commit a4086ac93f0b894977cbb6a3768e9335a613a602
Author: Adam Young <email address hidden>
Date: Thu Feb 21 11:09:57 2013 -0500

    Fix id_to_dn for creating objects

    Only do the lookup if the scope is not ONELEVEL
    For ONELEVEL, there is no point in paying the price of the lookup.

    If the object is not found for scoped queries, return the top level
    DN so the object can be created.

    Bug 1131265

    Change-Id: I1ca41bf87c3bdea30fbdf607b19192f37dd0bfd6

Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.