Unnecessary dependency on qemu-img by powervm driver

Bug #1131033 reported by David Peraza
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
David Peraza

Bug Description

The nova.virt.powervm.blockdev module makes a call to fetch_to_raw which requires qemu-img on the system running compute node. Since powervm only supports raw files there is no need to make image conversion and therefore depend on qemu-img. Linux on Power RHEL distro does not include quemu-img by default so this could be an issue that could come up on client shops. To avoid this we can just make a call to images.fetch instead of images.fetch_to_raw. I can provide this fix if assigned to me.

David Peraza (dperaza)
Changed in nova:
assignee: nobody → David Peraza (dperaza)
Revision history for this message
Michael Still (mikal) wrote :

What happens if a user has uploaded an image to glance which isn't in raw format? Surely you have to do conversion then?

Changed in nova:
status: New → Confirmed
Revision history for this message
David Peraza (dperaza) wrote :

Michael, in powervm only raw files are supported, I don't even thing you can get a powervm qcow2 or any other format since power uses block-base provisioning are raws will be a direct bit by bit copy of disk devices. Even if we figure out how to get a qcow2 from a power raw, linux on power RHEL for example does not include qemu-img by default so clients and contributors will most likely hit this issue.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22709

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/22709
Committed: http://github.com/openstack/nova/commit/edf15fdd38c670482848d2407a013a2ec4addd17
Submitter: Jenkins
Branch: master

commit edf15fdd38c670482848d2407a013a2ec4addd17
Author: David Peraza <email address hidden>
Date: Thu Feb 21 23:42:14 2013 +0000

    Removes unnecessary qemu-img dependency on powervm driver

    Fixes bug 1131033

    Power VM driver is using qemu-img through the fetch_to_raw call
    No need to attempt a conversion since power images can only
    be represented with the raw format, removing thus the need for
    any conversions by calling fetch instead of fetch_to_raw.

    Change-Id: I94b46e184cb87924a4754a0a48d9c2013a3eb756

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.