Should add 'break's in for loops in instance.py

[Ian Main]

resources/instance.py tries to match instance ids and flavor ids in a for loop but does not break when they are found.

[Steven Hardy (shardy)]

Note this is related to bug 1072948, which was closed invalid without fixing, I'm not sure why.

We need to fix all the while(1) stuff in instance.py so all those polling loops timeout after a number of retries or specific timeout.

[Angus Salkeld (asalkeld)]

What is wrong with relying on the stack timeout?
It will throw you an exception and you are out of there.
If you try split up the timeout between resources it is going
to get messy (how much for each one?)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/23243

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/23243
Committed: http://github.com/openstack/heat/commit/a7d22ff1e2c59fc97421ec6c1c5cfaac18d0481f
Submitter: Jenkins
Branch: master

commit a7d22ff1e2c59fc97421ec6c1c5cfaac18d0481f
Author: Ian Main <email address hidden>
Date: Thu Feb 28 18:03:26 2013 -0800

    Add breaks to for loops

    This just adds breaks to a couple of matching for loops in instance.py.

    Fixes: bug #1130898
    Change-Id: Iacfa040ba3a400b506e4fbc63c513eb3e67ecb11