Possible unused volume_id=volume_id lines in cinder/volume/manager.py

Bug #1130867 reported by stephen mulcahy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Mike Perez

Bug Description

Looking at an unrelated bug, I notice a number of LOG.xxx() calls that include a parameter 'volume_id=volume_id' even in messages which don't actually include a format specifier. e.g.

           LOG.debug(_("Retry info not present, will not reschedule"),
                      volume_id=volume_id)

            LOG.debug(_("No request spec, will not reschedule"),
                      volume_id=volume_id)

Mike Perez (thingee)
Changed in cinder:
assignee: nobody → Mike Perez (thingee)
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/23987

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/23987
Committed: http://github.com/openstack/cinder/commit/3a3726c6079b2de4cbe605f4584ffe87dcc169b0
Submitter: Jenkins
Branch: master

commit 3a3726c6079b2de4cbe605f4584ffe87dcc169b0
Author: Mike Perez <email address hidden>
Date: Sat Mar 9 00:40:39 2013 -0800

    Remove/update unused log arguements in manager

    Fixes: bug #1130867
    Change-Id: I6f9a9c33530e92fa9ce22bd44ef7c40f7e355b04

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24037

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/24037
Committed: http://github.com/openstack/cinder/commit/4e41878082469f77d265b39e045e22fa15edca0c
Submitter: Jenkins
Branch: master

commit 4e41878082469f77d265b39e045e22fa15edca0c
Author: xiaoxi_chen <email address hidden>
Date: Mon Mar 11 11:06:21 2013 +0800

    update error log arguements in filter scheduler

    There's one log issue in filter scheduler fell off radar in previous
    fix, this change closes the gap.

    Fixes: bug #1130867

    Change-Id: I78def31bd9ff4349cd1332cb96ef6311ce9eac20

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.