Volumes fail to boot: iscsiadm exit code 21

[Dan Prince]

In Grizzly 933365a ( Enable multipath for libvirt iSCSI Volume Driver) we broke Volume support on Fedora.

I'm not getting the following exceptions when running volume tests:

2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/volume.py", line 409, in _run_iscsiadm_bare
2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] check_exit_code=check_exit_code)
2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] File "/usr/lib/python2.7/site-packages/nova/utils.py", line 243, in execute
2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] cmd=' '.join(cmd))
2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] ProcessExecutionError: Unexpected error while running command.
2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] Command: sudo nova-rootwrap /etc/nova/rootwrap.conf iscsiadm -m session
2013-02-20 09:18:55.309 1288 TRACE nova.compute.manager [instance: a489fbfc-62b6-430c-809d-c51f6b82464b] Exit code: 21

----

The issue is we need to support exit code 21 explicitly in the _run_iscsiadm_bare exit code checks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/22431

[Chuck Short (zulcss)]

ditto on ubuntu

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/22431
Committed: http://github.com/openstack/nova/commit/13eee3d1d7b40bc334d663b7cea7c65a8f960dfe
Submitter: Jenkins
Branch: master

commit 13eee3d1d7b40bc334d663b7cea7c65a8f960dfe
Author: Dan Prince <email address hidden>
Date: Wed Feb 20 10:20:03 2013 -0500

    Allow exit code 21 for 'iscsiadm -m session'.

    Updates the libvirt volume driver so that it properly handles
    exit code 21 in the active session check. This fixes issues
    in running the command on Fedora 17.

    This behaviour was broken in 933365a (multipath libvirt iscsi).

    Fixes LP Bug #1130718.

    Change-Id: I80de4c09ba857d550734f9bd0dfc0c40bfd5036a