N302 is broken in hacking.py

Bug #1130411 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Vish Ishaya

Bug Description

http://logs.openstack.org/22078/11/check/gate-nova-pep8/20937/console.html

Says "import only modules.'from oslo.config import cfg' does not import a module"

but python shows cfg is a module

>>> from oslo.config import cfg
>>> isinstance(cfg, types.ModuleType)
True

Changed in nova:
assignee: nobody → Vish Ishaya (vishvananda)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/22385
Committed: http://github.com/openstack/nova/commit/3b649422a61dee822d813c6fbf9afb46569587b2
Submitter: Jenkins
Branch: master

commit 3b649422a61dee822d813c6fbf9afb46569587b2
Author: Vishvananda Ishaya <email address hidden>
Date: Tue Feb 19 16:59:53 2013 -0800

    Fix hacking test to handle namespace packages.

    This removes our workaround for namespace packages and improves
    detection of missing imports due to non-existent dependencies.

    Fixes bug 1130411

    Change-Id: I89ee8249580e395f786289792cdf74219d041f2f

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.