DHCP agent should exit if the interface driver isn't provided

Bug #1130052 reported by Édouard Thuleau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Gary Kotton

Bug Description

If the configuration flag 'interface_driver' isn't set in the configuration file of DHCP agent, the agent should exit with error log just after trying to start.
Like it's done with l3 agent: https://github.com/openstack/quantum/blob/master/quantum/agent/l3_agent.py#L158

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22290

Changed in quantum:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Gary Kotton (garyk)
Changed in quantum:
importance: Undecided → Low
milestone: none → grizzly-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/22290
Committed: http://github.com/openstack/quantum/commit/61b2cf8e6e7cf520876443d1d64c100645746ae4
Submitter: Jenkins
Branch: master

commit 61b2cf8e6e7cf520876443d1d64c100645746ae4
Author: Gary Kotton <email address hidden>
Date: Tue Feb 19 11:34:00 2013 +0000

    Exit if DHCP agent interface_driver is not defined

    Fixes bug 1130052

    In addition to this:
    Uses "raise SystemExit()" instaed of the exit for the L3
    agent.

    Change-Id: I8130745c9de62619189e158944fa9e4ed25be774

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.