ip_lib does not properly handle existing route for add_gateway

[dan wendlandt]

when adding a gateway route, ip_lib should ignore an error if the route already exists. it does not.

ntum/agent/dhcp_agent.py", line 538, in setup 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent device.route.add_gateway(gateway_ip) 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent File "/opt/stack/quantum/quantum/agent/linux/ip_lib.py", line 304, in add_gateway 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent self._as_root(*args) 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent File "/opt/stack/quantum/quantum/agent/linux/ip_lib.py", line 160, in _as_root 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent kwargs.get('use_root_namespace', False)) 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent File "/opt/stack/quantum/quantum/agent/linux/ip_lib.py", line 47, in _as_root 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent namespace) 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent File "/opt/stack/quantum/quantum/agent/linux/ip_lib.py", line 58, in _execute 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent root_helper=root_helper) 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent File "/opt/stack/quantum/quantum/agent/linux/utils.py", line 60, in execute 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent raise RuntimeError(m) 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent RuntimeError: 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent Command: ['sudo', '/usr/local/bin/quantum-rootwrap', '/etc/quantum/rootwrap.conf', 'ip', 'netns', 'exec', 'qdhcp-562f78f3-c9a8-43c4-b8e5-5fee1414c9ed', 'ip', 'route', 'add', 'default', 'via', '169.254.169.253', 'dev', 'tap52bd9baf-89'] 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent Exit code: 2 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent Stdout: '' 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent Stderr: 'RTNETLINK answers: File exists\n' 2013-02-18 18:32:39.964 10421 TRACE quantum.agent.dhcp_agent

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/22791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/22791
Committed: http://github.com/openstack/quantum/commit/063b7ee3a35a266eaf6548c30c697e3d55748288
Submitter: Jenkins
Branch: master

commit 063b7ee3a35a266eaf6548c30c697e3d55748288
Author: Gary Kotton <email address hidden>
Date: Sun Feb 24 10:30:08 2013 +0000

    Enabled add gateway to refrain from checking exit code

    Fixes bug 1129741

    Change-Id: Ibb9a0e1c0f0e5ad610c4f45ae65eb82e25a57b94