"log out" will error with a 404 and an OOPS code in various pages
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Robert Collins | ||
Bug Description
Any page in Launchpad that has a traversal error ( such as <https:/
Symptoms: clicking on the Log Out button shown on many pages will show a 404 and explain that an error has happened, giving an OOPS ID to seek support with.
What should happen: You're logged out, and whatever launchpad does when you log out should happen. However you do not get logged out.
OOPS-1908S71
analysis
--------
+logout is a regular form which we adapt other objects to. Objects that are not traversable for any reason (private, don't exist, etc) never hit the +logout form code, so the log out never happens.
possible fixes
--------------
* Use /+logout as the form rather than making it be based on the current url.
* Don't use regular form and traversal machinery to handle +logout: special case it in the publisher.
Related branches
- Steve Kowalik (community): Approve (code)
- William Grant: Approve (code*)
- Martin Pool (community): Approve (code*)
-
Diff: 12 lines (+1/-1)1 file modifiedlib/canonical/launchpad/templates/launchpad-loginstatus.pt (+1/-1)
| Changed in launchpad: | |
| importance: | Undecided → Low |
| status: | Unconfirmed → Confirmed |
| Changed in launchpad: | |
| importance: | Low → Critical |
| tags: |
added: oops removed: lp-foundations |
| description: | updated |
| description: | updated |
| description: | updated |
| summary: |
- "Log Out" doesn't work on deep 404 page + "log out" will error with a 404 and an OOPS code in various pages |
| description: | updated |
| Changed in launchpad: | |
| assignee: | nobody → Robert Collins (lifeless) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote | #1 |
| Changed in launchpad: | |
| milestone: | none → 11.05 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
Fixed in stable r12882 <http://