Common setup functions do not work when used in a git submodule

Bug #1126416 reported by Robert Myers
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Undecided
Robert Myers
Grizzly
Fix Released
Undecided
Robert Myers

Bug Description

There are several functions in the common setup that check for the existence of a directory named '.git'. This fails when the project added as a git submodule. When a submodule is created the '.git' is actually a file that points to the correct location of the submodule .git folder like this 'gitdir: ../.git/modules/nova', ie. the parent repository .git folder.

The check should change from:

os.path.isdir('.git')

to:

os.path.exists('.git')

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22055

Changed in oslo:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/22067

Changed in oslo:
assignee: Davanum Srinivas (DIMS) (dims-v) → Robert Myers (rmyers)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/22067
Committed: http://github.com/openstack/oslo-incubator/commit/8ce59472653439d646309395bf195ec6163ff29a
Submitter: Jenkins
Branch: master

commit 8ce59472653439d646309395bf195ec6163ff29a
Author: Robert Myers <email address hidden>
Date: Fri Feb 15 14:32:07 2013 -0600

    Change the check for the existence of .git directory.

    In common setup the check for the .git directory is too
    restrictive. Instead of checking that it is a directory just
    check to see if it exists. That way if the project is part
    of a submodule it will continue to work correctly.

    Change-Id: If6b6531ab5778ac17537e3f18bde1844620c8316
    Fixes: bug 1126416

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.