Use label instead of id in recording in-house use prompt

[[e-mail]]

EG2.2.5

When recording in-house with over 21 uses, there is a prompt which says: "Are you sure you want to mark 9 as having been used 21 times?"

One of our libraries was confused by 9 in the msg, which is the id of the selected non-cat type. Can we use the label of the non-cat type instead of the id in the prompt?

Tina
Sitka

[Ben Shum (bshum)]

A note for people testing this behavior: You need the library setting for "Record In-House Use: # of uses threshold for Are You Sure? dialog" enabled and set to a specific number (that you then exceed to get the prompt).

Confirmed that the ID for non-cat types are being passed as the variable.

[Ben Shum (bshum)]

In file Open-ILS/xul/staff_client/server/circ/in_house_use.js, there already appears to be some work towards using the name instead of the label. See lines 232 and 233:

barcode = ( obj.controller.view.in_house_use_menu.value );
//barcode = obj.data.hash.cnct[ obj.controller.view.in_house_use_menu.value ].name()

If I comment out the first line and then uncomment the second (and add a semi-colon at the end), I get the name of the non-cat instead of the ID when testing the options. phasefx++ for thinking ahead!

[Ben Shum (bshum)]

Thanks for taking a look at this the other day in IRC Jason.

I've created a working branch applying the changes I described above in comment 2.

See: user/bshum/in-house-use-label

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/in-house-use-label

[Bill Erickson (berick)]

Confirmed, tested, and pushed to 2.4+. Thanks, Tina and Ben.