add-fixed-ip doesn't update nwfilter in libvirt driver

Bug #1124722 reported by Chet Burgess
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Chet Burgess

Bug Description

When using nova add-fixed-ip the result is we have multiple ips per mac address. This leads to needing multiple IPs addresses in the libvirt nwfilter. We need to support this during initial XML generation/regeneration and add hooks to dynamically updated the nwfilter in libvirt when the IP is added.

Chet Burgess (cfb-n)
Changed in nova:
assignee: nobody → Chet Burgess (cfb-n)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22369

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/22374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/22369
Committed: http://github.com/openstack/nova/commit/660342ab7b4accbd1847a9016402744afe71acc1
Submitter: Jenkins
Branch: master

commit 660342ab7b4accbd1847a9016402744afe71acc1
Author: Chet Burgess <email address hidden>
Date: Tue Feb 19 07:20:24 2013 +0000

    Refactor nwfilter parameters

    * libvirt < 1.0.1 does not allow dynamically updating filter
      parameters inside an interface block of theinstance XML. To
      address this we move the nwfilter paramters from the instance
      XML to the per-instance base nwfilter.

    Relates to bug #1124722

    Change-Id: I50ec5dcffa8ff0232ae0aba0a08fce5151962238

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/22154
Committed: http://github.com/openstack/nova/commit/e43e4d68e97a046229795a61d139762d20d38907
Submitter: Jenkins
Branch: master

commit e43e4d68e97a046229795a61d139762d20d38907
Author: Chet Burgess <email address hidden>
Date: Tue Feb 19 22:12:43 2013 +0000

    Make add-fixed-ip update nwfilter wth in libvirt

    Add inject_network_info to the libvirt driver so that the
    add-fixed-ip call will trigger a refresh of the nwfilters.

    Change-Id: I00eccf34b8f92fb1e26a72e4bddb47dd39c4558f
    Fixes: bug #1124722

Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.