add-fixed-ip causes traceback

[Vish Ishaya]

nova add-fixed-ip leads to a traceback in nova-network
2013-02-13 16:10:57.711 ERROR nova.openstack.common.rpc.amqp [req-434b8722-566c-4345-933a-5646277cd6ef demo demo] Exception during message handling2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp Traceback (most recent call last):2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/openstack/common/rpc/amqp.py", line 276, in _process_data2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/openstack/common/rpc/dispatcher.py", line 133, in dispatch2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/network/manager.py", line 756, in add_fixed_ip_to_instance2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp self._allocate_fixed_ips(context, instance_id, host, [network])2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/network/manager.py", line 212, in _allocate_fixed_ips
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp vpn=vpn, address=address)
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/network/manager.py", line 801, in allocate_fixed_ip
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp instance_ref = self.db.instance_get(context, instance_id)
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/db/api.py", line 593, in instance_get
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp return IMPL.instance_get(context, instance_id)
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/db/sqlalchemy/api.py", line 137, in wrapper
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp return f(*args, **kwargs)
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp File "/opt/stack/nova/nova/db/sqlalchemy/api.py", line 1520, in instance_get
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp raise exception.InstanceNotFound(instance_id=instance_id)
2013-02-13 16:10:57.711 TRACE nova.openstack.common.rpc.amqp InstanceNotFound: Instance f96d5c44-6c17-46cb-8b5c-057717ce076d could not be found.

there seems to be quite a bit of mixing of instance['id'] with instance['uuid']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21927

[Sean Dague (sdague)]

Adding tempest because we should have a test case for this there as well. As Matt's building out the master missing test case list, assigning to him for now for attention.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/21927
Committed: http://github.com/openstack/nova/commit/65dbf21c91729fa20fed95e1cf69cda6421e9a45
Submitter: Jenkins
Branch: master

commit 65dbf21c91729fa20fed95e1cf69cda6421e9a45
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Feb 13 12:53:06 2013 -0800

    Fix add-fixed-ip and remove-fixed-ip.

    There were various places that were passing an integer id from
    network api to network manager. On the manager side we need the
    uuid so this patch updates everything to send the uuid.

    Secondarily, the network info cache wasn't being properly updated
    upon return from add-fixed-ip and remove-fixed-ip, so this
    changes the code to update the info cache as well.

    Fixes bug 1124674

    Change-Id: I632b39eb3963998cf42c02584dc9275a8aae243d