Extra, pointless query executed when overlapping IPs are disabled

Bug #1124363 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Salvatore Orlando

Bug Description

In the current code, subnet cidr validation is performed as follows:
1) Retrieve subnets for a network
2) If overlapping IPs are disabled, load all subnets from the DB

in #1 we execute an extra query that we can avoid.

Tags: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21900

Changed in quantum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/21900
Committed: http://github.com/openstack/quantum/commit/50cee94a808c0eb4d9af36a8da0026ba4f362d6d
Submitter: Jenkins
Branch: master

commit 50cee94a808c0eb4d9af36a8da0026ba4f362d6d
Author: Salvatore Orlando <email address hidden>
Date: Wed Feb 13 10:07:24 2013 -0800

    Avoid extra query when overlapping IPs are disabled

    Bug 1124363

    Change-Id: I431d19a987e18ec2648d9cb0aad185e5ba68f830

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.