Glance V1 API documentation inaccuracy

[John Lenihan]

According to the V1 Glance API docs at http://docs.openstack.org/developer/glance/glanceapi.html#add-a-new-image if I am adding a new image the headers 'x-image-meta-disk_format' and 'x-image-meta-container_format' are optional. However using the latest glance devstack environment an attempt to create a new image will fail if I do not specify these headers.

If the above headers are not present the API throws a 400 Bad Request with message either "Invalid disk format 'None' for image." if the x-image-meta-disk_format header is missing, or else "Invalid container format 'None' for image." if the x-image-meta-container_format header is missing.

[Anita Kuno (anteaya)]

I can confirm that 'x-image-meta-container_format' is required to add an image in addition to 'x-image-meta-name' which is identified as necessary in the linked documentation.

I am able to add an image using cURL that does not pass the 'x-image-meta-disk_format'.

[Brian Waldon (bcwaldon)]

You can create an image without disk/container formats if you do not upload image data. If you are uploading that image data, you must set both container and disk_format. I think this fact should be added to the doc page to solve this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30724

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/30724
Committed: http://github.com/openstack/glance/commit/02fc5ba589df74d4404fee6fd6dc897e06c7d886
Submitter: Jenkins
Branch: master

commit 02fc5ba589df74d4404fee6fd6dc897e06c7d886
Author: Paul Bourke <email address hidden>
Date: Mon May 27 16:08:42 2013 +0000

    Add documentation on reserving a Glance image

    This lets us refer to the fact that some optional headers are in fact
    required unless reserving an image.

    Fixes bug 1124224

    Change-Id: I5646d4dc130efecf991573b363eb1a665012b7df