Loadbalancing: Missing validation in Vip creation

[Avishay Balderman]

Both Vip and Pool has a field named protocol. Valid values for this field are : "HTTP", "HTTPS", "TCP"
The code needs to validate the combinations of Vip(protocol) and Pool(protocol)
Valid combinations are:
1) Vip(TCP) -- Pool(TCP)
2) Vip(HTTP) -- Pool(HTTP)
3) Vip(HTTPS) -- Pool(HTTPS)

[Avishay Balderman (avishayb)]

For cases #1 and #3 Stickiness can be "SOURCE_IP" only.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24224

[Ryan O'Hara (rohara)]

It was not obvious to me how to set session persistence when creating a VIP, so I'm not sure how to validate "stickyness" based on protocol. If I'm missing something, please advise.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24224
Committed: http://github.com/openstack/quantum/commit/9a15b11794dbf945f0e9b9705ae510d3b378287d
Submitter: Jenkins
Branch: master

commit 9a15b11794dbf945f0e9b9705ae510d3b378287d
Author: Ryan O'Hara <email address hidden>
Date: Tue Mar 12 13:01:23 2013 -0500

    Validate protocol when creating VIP.

    Fixes: bug #1123114

    When creating a VIP, check that the protocol matches the protocol
    for the associated pool. If not, raise an exception.

    Change-Id: Iba318eda935ccc89dbe8244e00f36ebdfcce65e0