openstack-common.conf should support multi-line values

[Monty Taylor]

Can you tell what changed here:

index 7ca64ce..077a3e3 100644
--- a/openstack-common.conf
+++ b/openstack-common.conf
@@ -1,5 +1,5 @@
 [DEFAULT]
 # The list of modules to copy from openstack-common
-modules=cfg,context,eventlet_backdoor,exception,excutils,fileutils,gettextutils,importutils,iniparser,install_venv_common,jsonutils,local,lockutils,log,loopingcall,network_utils,notifier,periodic_task,policy,rpc,service,setup,threadgroup,timeutils,uuidutils,version
+modules=cfg,context,eventlet_backdoor,exception,excutils,fileutils,flakes,gettextutils,hacking,importutils,iniparser,install_venv_common,jsonutils,local,lockutils,log,loopingcall,network_utils,notifier,periodic_task,policy,rpc,service,setup,threadgroup,timeutils,uuidutils,version
 # The base module to hold the copy of openstack.common
 base=quantum

Of course not - the lines are too long. If the file could be:

modules=cfg,
  context,
  eventlet,

etc. - it would make diffs WAY more readable.

[Doug Hellmann (doug-hellmann)]

It doesn't seem like we should have to invent our own format to have this feature.

[Doug Hellmann (doug-hellmann)]

In fact, ConfigObj may just do this. Are there any special features of the existing openstack/common/iniparser.py that aren't supported by ConfigObj? http://pypi.python.org/pypi/configobj

[Mark McLoughlin (markmc)]

Doug: iniparser was needed for MultiStrOpt support. See https://review.openstack.org/5375

"I'm not jumping for joy that we're bringing another .ini file parser into the world" :)

[Mark McLoughlin (markmc)]

Uh, duh - can we make this value a MultiStrOpt ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24220

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24220
Committed: http://github.com/openstack/oslo-incubator/commit/a2223d49c8d5e27951b702a5b8a59a278f03fb74
Submitter: Jenkins
Branch: master

commit a2223d49c8d5e27951b702a5b8a59a278f03fb74
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 12 17:21:50 2013 +0000

    update.py: support one-module-per-line configuration

    Fixes bug #1122701

    Allow:

      module=foo
      module=bar

    rather than

      modules=foo,bar

    to make reviewing changes easier.

    Change-Id: Ic0a7fb28fd34f530c93806a5fb79ed3dc3bc494e