Waveform progress bar looks odd w/ end-processing visualized.

Bug #1120610 reported by RJ Skerry-Ryan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Daniel Schürmann

Bug Description

The waveform progress bar lags behind the actual waveform and this is confusing. Worse yet, when the waveform reaches 100%, the progress bar just stops at about 90% and sits there until the final processing (e.g. replaygain calculation) is done and then it goes away.

I propose when the waveform progress reaches 100% we should draw text on the waveform like "Finalizing" or something to let the user know it isn't done yet.

Related branches

RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: none → 1.11.0
Revision history for this message
jus (jus) wrote :

Agree, but what is the additional progress bar good for at all?
If a waveform is analyzed on fist load we have the "Analyzing" text and the waveform overview grows gradually with the analyzing progress. If the analysis is finished, the waveform is completely shown. That alone is simple and functional enough IMO.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Daniel Schürmann (daschuer) wrote :

The current implementation is the result of fixing:
Bug #1008721 Reflect analyser finished by waveform overview
Bug #1085701 woverview axes as progress when silence
Bug #1100478 no progress bar when waveform already analyzed
Bug #840860 reload track metadata changes gain of a playing track

I agree that this was done driven by the technical point of view not the aesthetic one.
Any Idea to beautify it?

For now I will try RJ's proposal.

Changed in mixxx:
assignee: nobody → Daniel Schürmann (daschuer)
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Here it is:

Revision history for this message
Daniel Schürmann (daschuer) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 1120610] Re: Waveform progress bar looks odd w/ end-processing visualized.

nice -- looks good to me. thanks daniel

On Wed, Feb 27, 2013 at 2:47 PM, Daniel Schürmann <
<email address hidden>> wrote:

> ** Patch added: "finalize_text.patch"
>
> https://bugs.launchpad.net/mixxx/+bug/1120610/+attachment/3550052/+files/finalize_text.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1120610
>
> Title:
> Waveform progress bar looks odd w/ end-processing visualized.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1120610/+subscriptions
>

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Committed to revision lp:mixxx/1.11 3767.

Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6910

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.