some sub-title seems not consistent in i18n and format

Bug #1120551 reported by Kun Huang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Emilien Macchi
Grizzly
Fix Released
Undecided
Emilien Macchi

Bug Description

Let's have look at those in template. There're some examples below:

1. Details vs Detail
huangkun@sbLenovo:~/celtics/horizon/openstack_dashboard/dashboards$ cat project/routers/templates/routers/detail.html
{% extends 'base.html' %}
{% load i18n %}
{% block title %}{% trans "Router Details" %}{% endblock %}

{% block page_header %}
  {% include "horizon/common/_page_header.html" with title=_("Router Detail") %}
{% endblock page_header %}

{% block main %}
{% include "project/routers/_detail_overview.html" %}
<hr>
<div id="interfaces">
   {{ interfaces_table.render }}
</div>
{% endblock %}

2. "Create Router" vs "Create a Router"
3. missing i18n translation in title (block title)
huangkun@sbLenovo:~/celtics/horizon/openstack_dashboard/dashboards$ cat project/routers/templates/routers/create.html
{% extends 'base.html' %}
{% load i18n %}
{% block title %}Create Router{% endblock %}

{% block page_header %}
  {% include "horizon/common/_page_header.html" with title=_("Create a Router") %}
{% endblock page_header %}

{% block main %}
    {% include 'project/routers/_create.html' %}
{% endblock %}

Does that consistency be serious? in i18n or format.

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

Increased consistency would be fantastic. I try to fix these things as I see them. Contributions are welcome.

Changed in horizon:
importance: Undecided → Low
status: New → Confirmed
Julie Pichon (jpichon)
tags: added: low-hanging-fruit
Changed in horizon:
assignee: nobody → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24899

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

The number of pages of using "Details" vs "Detail" is around the same. Are we using "Details" going forward?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/24899
Committed: http://github.com/openstack/horizon/commit/40ab94501330eb9e740e82619e20d1235301f70b
Submitter: Jenkins
Branch: master

commit 40ab94501330eb9e740e82619e20d1235301f70b
Author: EmilienM <email address hidden>
Date: Wed Mar 20 14:59:19 2013 +0100

    Fix some not-consistent titles for virtual routers management

    - Replace "Detail" by "Details"
    - Replace "Create a router" by "Create router" (like other OpenStack projects)

    Fix bug #1120551

    Change-Id: I8b6e01b4400a044dfab7322abb251fe034ae010b

Changed in horizon:
status: In Progress → Fix Committed
Kieran Spear (kspear)
Changed in horizon:
milestone: none → havana-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/28017

tags: added: grizzly-backport-potential
removed: low-hanging-fruit
Julie Pichon (jpichon)
tags: removed: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/grizzly)

Reviewed: https://review.openstack.org/28017
Committed: http://github.com/openstack/horizon/commit/4b3ebde911b8675b92a08f98bb8197a888baf8e8
Submitter: Jenkins
Branch: stable/grizzly

commit 4b3ebde911b8675b92a08f98bb8197a888baf8e8
Author: EmilienM <email address hidden>
Date: Wed Mar 20 14:59:19 2013 +0100

    Fix some not-consistent titles for virtual routers management

    - Replace "Detail" by "Details"
    - Replace "Create a router" by "Create router" (like other OpenStack projects)

    Fix bug #1120551
    Cherry-picked from https://review.openstack.org/#/c/24899/

    Change-Id: I8b6e01b4400a044dfab7322abb251fe034ae010b

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.