request() got an unexpected keyword argument 'config'

[Jonathan Harker]

requests.request() >= v1.0.0 does not accept the keyword argument 'config', but the pip requirements allows for versions up to v1.1.0. When using requests==1.0.4 the following exception is raised:

File "build/bdist.linux-x86_64/egg/swiftclient/client.py", line 328, in get_auth
  File "build/bdist.linux-x86_64/egg/swiftclient/client.py", line 265, in get_keystoneclient_2_0
swiftclient.client.ClientException: Authorization Failure. Authorization Failed: request() got an unexpected keyword argument 'config'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21258

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/21258
Committed: http://github.com/openstack/python-keystoneclient/commit/a564b88e688282a16fcb27b71004576468bf1cf0
Submitter: Jenkins
Branch: master

commit a564b88e688282a16fcb27b71004576468bf1cf0
Author: K Jonathan Harker <email address hidden>
Date: Tue Feb 5 14:59:49 2013 -0800

    Pin requests module more strictly.

    requests.request() does not accept the keyword argument 'config'
    (used on keystoneclient/client.py:339) after version 1.0.0.

    Fixes bug #1116740

    Change-Id: I0a778849ff44a76a2647aa46057fdb35401fae5f

[Jay Buffington (jaybuff)]

The fix to this bug introduces a new bug:

Keystone's test-requires has a version of requests that is in direct conflict with the version that is set in keystoneclient's pip-requires in commit a564b88e6

[keystone] $ git describe
grizzly-2-74-g8ec247b

[keystone] $ cat tools/test-requires |grep requests
requests>=1.0.0 # replaces httplib2 in keystoneclient >=0.2.1

Since python-keystoneclient is required by the keystone test-requires you can't satisfy all dependencies to be able to run the tests. I'd like to see this change reverted in favor of a better solution being worked on in https://review.openstack.org/#/c/21313/

[Jay Buffington (jaybuff)]

Sorry, I believe my previous comment was barking up the wrong tree. The problem is that a5b7fcf5f96a42bb4ac8110894b5cc146c552ad9 was committed to keystone before https://review.openstack.org/#/c/20127/ was merged into keystoneclient.

The commit related to this bug (a564b88e6) correctly reflects the fact that keystoneclient doesn't currently work with requests<1.1.

[Pete Zaitcev (zaitcev)]

This is fixed now, right?