HTTP 405 code is not handled as exception

[Lin Hua Cheng]

Keystone publicURL expose a subset of Keystone APIs, and internalURL exposed the Admin REST API.

If the user misconfigured the endpoint and sends a Admin REST call to the publicURL it would returned a 405 error since the API is not supported.

Currently, keystoneclient does not recognized 405 error and treats it as success.

Keystone-client should treat all HTTP code above 400 as error instead of selecting of picking the error code to handle

Related code in client.py:

    if resp.status_code in (400, 401, 403, 404, 408, 409, 413, 500, 501):

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21238

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/21239

[Dolph Mathews (dolph)]

"Keystone publicURL expose a subset of Keystone APIs, and internalURL exposed the Admin REST API."

The "public" and "internal" endpoints are both intended to fulfill the public API.

The "admin" endpoint is intended to be "non-public" and is implied to also be "internal."

[Lin Hua Cheng (lin-hua-cheng)]

Just to confirm my understanding, only "admin" endpoint is expected to contain the private APIs?

If yes, so "internal" endpoint is not expected that to support private API?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/21239
Committed: http://github.com/openstack/python-keystoneclient/commit/382441a9f18c583c071bf69d25cd44f5ec3555bb
Submitter: Jenkins
Branch: master

commit 382441a9f18c583c071bf69d25cd44f5ec3555bb
Author: Lin Hua Cheng <email address hidden>
Date: Tue Feb 5 11:17:53 2013 -0800

    Treat HTTP code 400 and above as error.

    Fixes bug 1116559.

    Change-Id: I4b12176599686f7e545b63c8e54cf9da6a1f963e