Recoverable error should be logged at WARN level

[Lin Hua Cheng]

In the error handling of horizon, recoverable error is logged at ERROR LEVEL.

    if issubclass(exc_type, RECOVERABLE):
        wrap = True
        if not force_silence and not handled and (not ignore or force_log):
            log_method(error_color("Recoverable error: %s" % exc_value))
        if not ignore and not handled:
            messages.error(request, message or exc_value)
        if redirect:
            raise Http302(redirect)
        if not escalate:
            return RecoverableError # return to normal code flow

Recoverable exceptions are typically application exception or validation error that the user can fix.

Logging recoverable error as ERROR in the log might cause false alarm if there are log file monitoring is in place that looks for ERRORs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/20674

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/20674
Committed: http://github.com/openstack/horizon/commit/c2da2e25c6513ba8cd847a38e701a9a2426a1d18
Submitter: Jenkins
Branch: master

commit c2da2e25c6513ba8cd847a38e701a9a2426a1d18
Author: Lin Hua Cheng <email address hidden>
Date: Mon Jan 28 23:49:25 2013 -0800

    Default recoverable error to WARN log level.

    Fixes bug 1108631.

    Change-Id: Ibe76a7b0badf31e4aba63f6d7f42c461b7ea1023