Twisted use of pygtkcompat breaks support of old pygobject APIS
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-4-2 |
Fix Released
|
High
|
dobey | |||
Trunk |
Fix Released
|
Critical
|
dobey | |||
ubuntuone-client (Ubuntu) |
Fix Released
|
Undecided
|
dobey | |||
Raring |
Fix Released
|
Undecided
|
dobey |
Bug Description
This happens now, at least in tests, thanks to the new twisted in Ubuntu 13.04 using pygtkcompat:
Traceback (most recent call last):
File "/usr/bin/u1trial", line 40, in <module>
main()
File "/usr/lib/
suite = test_runner.
File "/usr/lib/
config[
File "/usr/lib/
module_suite = self._load_
File "/usr/lib/
module = __import__(modpath, None, None, [""])
File "/mnt/tarmac/
GIO_
File "/usr/lib/
return getattr(
File "/usr/lib/
self.__name__, name))
AttributeError: 'gi.repository.Gio' object has no attribute 'ERROR_
This is because we check for the old API being loaded first, and use gi only when it isn't in use. However, use of pygtkcompat in twisted's gireactor now, means that the things we were checking for are set in sys.modules, but actually point to the new APIs, which are not compatible.
Related branches
- Brian Curtin (community): Approve
- Paul Hummer (community): Approve
-
Diff: 346 lines (+42/-111)10 files modifiedbin/u1sdtool (+3/-8)
bin/ubuntuone-syncdaemon (+4/-8)
contrib/dbus-docs (+3/-6)
contrib/login_email_password.py (+3/-9)
tests/platform/notification/test_linux.py (+4/-15)
tests/platform/os_helper/test_linux.py (+5/-10)
ubuntuone/platform/notification/__init__.py (+1/-3)
ubuntuone/platform/notification/linux.py (+11/-29)
ubuntuone/platform/os_helper/linux.py (+5/-10)
ubuntuone/platform/sync_menu/linux.py (+3/-13)
Changed in ubuntuone-client (Ubuntu Raring): | |
status: | New → Triaged |
assignee: | nobody → Rodney Dawes (dobey) |
tags: | added: u1-api u1-by-automation u1-on-staging |
This bug was fixed in the package ubuntuone-client - 4.1.90-0ubuntu1
---------------
ubuntuone-client (4.1.90-0ubuntu1) raring; urgency=low
* New upstream release.
- Fix support for searching local files in cloud folders. (LP: #1101271)
- Various fixes to the test suite.
- Fix tritcask DataFile.write to flush with new libc6. (LP: #1093111)
- Remove most of the static glib bindings usage. (LP: #1108036)
- Avoid g_type_init with new versions of glib. (LP: #1100926)
- Replace simplejson usage with json. (LP: #1029094)
- Use a standard LC_CTYPE locale when the LANG is turkish. (LP: #997326)
* debian/control:
- Require newer version of ubuntu-sso-client for LANG fix.
- Update dependencies to drop fallbacks for static bindings.
-- Rodney Dawes <email address hidden> Tue, 29 Jan 2013 15:22:08 -0500