Session.execute() method is not wrapped by wrap_db_error

Bug #1107890 reported by Boris Pavlovic
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Boris Pavlovic

Bug Description

Session.execute() is called when we are calling Query.update() method. Without wrapping Session.execute() all exception that raises Query.update() wouldn't be wrapped by wrap_db_error() method.

Changed in nova:
assignee: nobody → Boris Pavlovic (boris-42)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20597

Changed in nova:
status: New → In Progress
Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/20597
Committed: http://github.com/openstack/nova/commit/487384fcc864ef1955f99cdf713cf5c2d77ec023
Submitter: Jenkins
Branch: master

commit 487384fcc864ef1955f99cdf713cf5c2d77ec023
Author: Boris Pavlovic <email address hidden>
Date: Mon Jan 28 17:16:15 2013 +0400

    Fix missing wrap_db_error for Session.execute() method

    We should add wrap_db_error for Session.execute() method, because
    Query.update() method will call Session.execute() and it is not inside
    Session.flush(), so exceptions from Query.update() wouldn't be wrapped.

    Add test for Session.flush() wrapper
    Add test for Session.execute() wrapper

    Fixes bug 1107890

    Change-Id: I96894e502f9f279999b61a1e66469e34a07a022d

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
status: Fix Released → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.